Don't enforce that a memory card has to have a .raw or .gcp file extension. #7975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
Techjar
reviewed
Apr 11, 2019
This was referenced Apr 21, 2019
3 tasks
AdmiralCurtiss
force-pushed
the
memcard-manager-filetypes
branch
from
fc17bdb to
119bf3e
Compare
|
This has been reduced to a trivial change with #8300 merged. |
|
Are we sure we want two strings in one |
|
Yeah, fair, I'll do that. |
AdmiralCurtiss
force-pushed
the
memcard-manager-filetypes
branch
from
119bf3e to
5614594
Compare
|
Yeah sure why not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorta implements this feature request: https://forums.dolphin-emu.org/Thread-support-bin-extension-for-gc-memory-card-manager
I've not actually added
*.binas a suggested filetype as that's very generic, but if someone wants to open a bin as a Memory Card, why not let them?