Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/NetPlayBrowser: Various small fixes #7967

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Apr 7, 2019

Changes:

  • Fixes the In-Game column being editable
  • Fixes the header getting bold when an item is selected
  • Adds a version column
  • Adds an option to show incompatible sessions

@spycrab spycrab force-pushed the qt_browser_improvements branch from 6f21703 to 75f1a5d Compare April 7, 2019 22:01
@Techjar
Copy link
Contributor

Techjar commented Apr 7, 2019

I have a couple suggestions to improve usability:

  1. Make incompatible versions red or something to make it more obvious why the row is disabled.
  2. Disable hide incompatible sessions by default, as I think it's likely to just confuse users when they don't see their friend's session, or possibly none at all.

@spycrab
Copy link
Contributor Author

spycrab commented Apr 7, 2019

Disable hide incompatible sessions by default, as I think it's likely to just confuse users when they don't see their friend's session.

No, I actually think that is more confusing as it presents users with a big list of entries that they will not be able to interact with.

The default UI state should be the most useful one, so I'd keep it this way.

Make incompatible versions red or something to make it obvious at a glance.

It being disabled should be obvious enough. Marking items as red also has many caveats regarding themability and accessibility.

@Techjar
Copy link
Contributor

Techjar commented Apr 7, 2019

No, I actually think that is more confusing as it presents users with a big list of entries that they will not be able to interact with.

I guess there's potential problems on both sides, but enabled by default presents a nicer UI, so fair enough.

It being disabled should be obvious enough. Marking items as red also has many caveats regarding themability and accessibility.

True. And I guess if hide incompatible is on by default, then it should be obvious that disabled means incompatible once a user turns that option off.

While we're fixing issues with this UI, could you also either remove the list refresh from onTextChanged or do the refresh asynchronously? My UI hangs for sometimes tens of seconds when typing into the Name and Game ID fields. Filtering name and game ID on the client side is probably the best solution here, as we already have the whole list anyways when we first open the window.

I also had the idea to have the disabled rows link to the appropriate build download page (through dolp.in), if it's feasible to do this. What are your thoughts on this?

@spycrab
Copy link
Contributor Author

spycrab commented Apr 7, 2019

I do not want to extend the scope of this PR beyond what's already in it

@spycrab spycrab merged commit 22f5590 into dolphin-emu:master Apr 8, 2019
@spycrab spycrab deleted the qt_browser_improvements branch April 8, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants