Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt/MainWindow: Fix segfault on exit while NetPlay is open #7960

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Qt/MainWindow: Fix segfault on exit while NetPlay is open #7960

merged 1 commit into from
Apr 5, 2019

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Apr 5, 2019

We ensure the NetPlay client and server have been deleted (which shuts down their threads) before exiting, otherwise the NetPlay thread segfaults upon trying to access m_dialog.

@JMC47 JMC47 merged commit a7ee00a into dolphin-emu:master Apr 5, 2019
@knisage

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spycrab spycrab spycrab approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Techjar @knisage @spycrab @JMC47