-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetPlay golf mode #7955
Merged
Merged
NetPlay golf mode #7955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techjar
force-pushed
the
netplay-golf-mode
branch
from
April 2, 2019 12:12
39c670a
to
9a1e503
Compare
This is a prerequisite for golf mode, as the client needs to be in control of sending pad states.
Techjar
force-pushed
the
netplay-golf-mode
branch
2 times, most recently
from
April 2, 2019 21:13
cd4aa00
to
199d2b6
Compare
Techjar
force-pushed
the
netplay-golf-mode
branch
from
April 2, 2019 21:20
199d2b6
to
bb45fa1
Compare
Works like a charm outside of a framelimiter bug that's been reported. |
Techjar
force-pushed
the
netplay-golf-mode
branch
from
April 4, 2019 10:30
bb45fa1
to
c88bab3
Compare
@dolphin-emu-bot rebuild |
BhaaLseN
reviewed
Apr 4, 2019
Techjar
force-pushed
the
netplay-golf-mode
branch
4 times, most recently
from
April 5, 2019 06:32
ea4bafe
to
a93c164
Compare
This is an extension of host input authority that allows switching the host (who has zero latency) on the fly, at the further expense of everyone else's latency. This is useful for turn-based games where the latency of players not on their turn doesn't matter. To become the so-called golfer, the player simply presses a hotkey. When the host is the golfer, latency is identical to normal host input authority.
Techjar
force-pushed
the
netplay-golf-mode
branch
from
April 5, 2019 11:01
a93c164
to
6c393f9
Compare
spycrab
approved these changes
Apr 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of host input authority that allows switching the "host" (who has zero latency) on the fly, at the further expense of everyone else's latency. This is useful for turn-based games where the latency of players not on their turn doesn't matter.
To become the so-called golfer, the player simply presses a hotkey. When the host is the golfer, latency is identical to normal host input authority.
As a design necessity, this also includes a refactor of host input authority to move the logic to the client side.
Todo List: