Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetPlay golf mode #7955

Merged
merged 3 commits into from
Apr 5, 2019
Merged

NetPlay golf mode #7955

merged 3 commits into from
Apr 5, 2019

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Apr 2, 2019

This is an extension of host input authority that allows switching the "host" (who has zero latency) on the fly, at the further expense of everyone else's latency. This is useful for turn-based games where the latency of players not on their turn doesn't matter.

To become the so-called golfer, the player simply presses a hotkey. When the host is the golfer, latency is identical to normal host input authority.

As a design necessity, this also includes a refactor of host input authority to move the logic to the client side.

Todo List:

  • Imgui overlay

@Techjar Techjar force-pushed the netplay-golf-mode branch from 39c670a to 9a1e503 Compare April 2, 2019 12:12
This is a prerequisite for golf mode, as the client needs to be in
control of sending pad states.
@Techjar Techjar force-pushed the netplay-golf-mode branch 2 times, most recently from cd4aa00 to 199d2b6 Compare April 2, 2019 21:13
@Techjar Techjar changed the title [WIP] NetPlay golf mode NetPlay golf mode Apr 2, 2019
@Techjar Techjar force-pushed the netplay-golf-mode branch from 199d2b6 to bb45fa1 Compare April 2, 2019 21:20
@JMC47
Copy link
Contributor

JMC47 commented Apr 4, 2019

Works like a charm outside of a framelimiter bug that's been reported.

@Techjar Techjar force-pushed the netplay-golf-mode branch from bb45fa1 to c88bab3 Compare April 4, 2019 10:30
@JMC47
Copy link
Contributor

JMC47 commented Apr 4, 2019

@dolphin-emu-bot rebuild

@Techjar Techjar force-pushed the netplay-golf-mode branch 4 times, most recently from ea4bafe to a93c164 Compare April 5, 2019 06:32
Techjar added 2 commits April 5, 2019 07:01
This is an extension of host input authority that allows switching the
host (who has zero latency) on the fly, at the further expense of
everyone else's latency. This is useful for turn-based games where the
latency of players not on their turn doesn't matter.

To become the so-called golfer, the player simply presses a hotkey.
When the host is the golfer, latency is identical to normal host input
authority.
@Techjar Techjar force-pushed the netplay-golf-mode branch from a93c164 to 6c393f9 Compare April 5, 2019 11:01
Copy link
Contributor

@spycrab spycrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spycrab spycrab merged commit e44433c into dolphin-emu:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants