-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/NetPlay: Implement session/server browser #7945
Conversation
27205c6
to
28f0b11
Compare
Bad password provided should be Incorrect password provided. |
2e978e4
to
35b4518
Compare
Fixed.
This dialog has been removed. |
|
||
if (!response) | ||
{ | ||
m_last_error = "NO_RESPONSE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These response checks seem to be duplicated in a few places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think those can be deduplicated in a reasonable manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a few could be replaced by a function that takes a url, performs a request, parses json and returns the json + error/status.
|
|
Important: |
836abd5
to
daaf8ac
Compare
I don't like all the abbreviated regions? I don't know what most of them are at a glance and it could confuse users. |
Yeah, they're not all very intuitive. Keep in mind that they preferably should be translatable as well. |
Regions are now displayed as |
1f6b844
to
36f99ad
Compare
TODO: