-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Fix touch IR #7921
Android: Fix touch IR #7921
Conversation
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/DirectoryInitialization.java
Outdated
Show resolved
Hide resolved
Most games map fine with the default values and I have yet to read a single complaint on mapping the touch pointer. Going to just leave it up to the users to setup mapping if the defaults are not correct.
I'm going to add some IR calibration logic which will move the in game cursor to maybe 3 or 4 select positions on the screen for the user to click/touch so the ideal Width/Height/Center settings can be calculated. I don't know if the game specific IR values should be removed or not. There are definitely some games that are going to need non-default values (Skyward Sword, for one). |
We can cross that bridge when we come to it. I'm just putting this up so we don't tag a beta with broken touch pointer. On the topic of game specific values, I looked over the forums and playstore reviews and didn't find a mention(after PR7500 was merged) of anyone complaining about the touch pointer not mapping 1-1. Seems that the users are able to do the mapping themselves when needed. I think this also plays into the fact that all mappings would need to be updated when any axis logic changes(like in pr7829). |
@dolphin-emu-bot rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes seem fine.
This fixes touch IR after improvements from PR7829.
Also I've removed the game specific IR values. Most games map fine with the default values and I have yet to read a single complaint on mapping the touch pointer. Going to just leave it up to the users to setup mapping if the defaults don't work for a specific game. @Helios747 You were right :)