-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Graphic setting description improvements #7810
Conversation
487a9dd
to
92acf19
Compare
Any review comments for this? This is the simplest PR I'm proposing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Very simple PR indeed, but for the best.
... Does anyone else want to review / merge this? |
...nobody? |
@Ebola16 Unfortunately I don't know if we have anyone right now that cares enough about Android to review or even test this. |
The code looks good overall. |
In |
Should be okay then, as long as we don't have many special cases like that. |
...n/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/SingleChoiceViewHolder.java
Outdated
Show resolved
Hide resolved
c2bf515
to
2e9b869
Compare
I tried a different approach but I'm not sure if I did it properly. Ready for review. |
...any other reviews? |
...if this looks good can it be merged? This is needed for future PRs. |
yolo |
Follow-up to #7591 and #7121.
Implements
SingleChoiceSettingDynamicDescriptions
and applies it to the Shader Compilation Mode setting.Pinging @mahdihijazi @zackhow @MayImilae and @JosJuice in case you're interested in this.