DSP: ARAM cleanup experiments #7740
Conversation
booto
force-pushed
the
aram-experiments
branch
from
65d28b8 to
d0a7211
Compare
|
|
booto
force-pushed
the
aram-experiments
branch
from
6222200 to
60b7c37
Compare
booto
force-pushed
the
aram-experiments
branch
2 times, most recently
from
7ff09ee to
1bb7392
Compare
|
This fixes the remaining issues in ATV Offroad Fury 2 in multiplayer. |
booto
force-pushed
the
aram-experiments
branch
3 times, most recently
from
653764b to
4464aa3
Compare
|
Wonder if this will fix my HSP issues. Poke me when this is done and I'll rewrite my HSP branch on top of it to find out. |
booto
force-pushed
the
aram-experiments
branch
from
4464aa3 to
a39e0d4
Compare
|
Seems it fixes Resident Evil 2 sound issues, at least for me. Need more testers, also for Residen Evil 3 Nemesis. |
|
The broken sound in the intro is still there for me in Resident Evil 2. I haven't tested any areas beyond that, though. |
|
Waiting on #7980 merge before rebasing/etc this. |
booto
changed the title
|
Everything seems to be working at a quick glance of ARAM sensitive games. |
Changes include: * Take into account how different size settings interact * Do ARAM DMA transfers in chunks rather than all-at-once
booto
force-pushed
the
aram-experiments
branch
3 times, most recently
from
1761395 to
052240a
Compare
| // ARAM is mirrored every 64MB (verified on real HW) - done in address conversion func | ||
| // Source/destination/count aligned to 32 bytes - done in MMIO handler | ||
|
|
||
| u32 lines_to_transfer = std::min(s_arDMA.Cnt.count / ARAM_LINE_SIZE, ARAM_MAX_TRANSFER_CHUNKING); |
There was a problem hiding this comment.
Nit: Please keep the naming style consistent.
There was a problem hiding this comment.
was this mostly about ticksToTransfer not being snake case? (fixed)
|
@dolphin-emu-bot rebuild |
|
This got abandoned but I tested it and the code is approved. |
|
@JMC47 This has broken a lot of things. New Super Mario Bros just straight up crashes with broken audio and i also can no longer get into the wii system menu immediately after installing this merge to the latest dev build. Switching to DSP LLE fixes the crashing but audio is still broken. |
|
That's interesting, I didn't test many Wii games since the Wii doesn't have ARAM. Probably a minor oversight. If it doesn't get fixed soon I can revert this. Thanks for the report! |
|
Yeah i'm finding that more games are affected including Donkey Kong Country Returns :( crashes shortly after the title screen |
|
It's likely that all Wii games are affected to some degree. |
|
Rolled back in #8344. |
Some experiments trying to clean up ARAM-related code that seems strange.