Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals: Add a stripped down version of minizip #7477

Merged
merged 1 commit into from Nov 17, 2018
Merged

Externals: Add a stripped down version of minizip #7477

merged 1 commit into from Nov 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2018

Cherry-picked 34707e9 - I was told that PR will probably never get finished.

It will be needed for an auto-updater for #7110 in the future and possibly other things.

@ghost
Copy link
Author

ghost commented Oct 9, 2018

It may be a bit premature, I don't mind leaving it until later, except if someone else needs it before that happens, they'd need it in the code beforehand, otherwise they'd have to manually get it first for themsefls.

I guess it's a time saver then, for those that are quite busy it may come handy.

@delroth delroth merged commit e6b2758 into dolphin-emu:master Nov 17, 2018
@ghost ghost deleted the ext-minizip branch November 19, 2018 01:28
@ryao
Copy link

ryao commented Nov 25, 2018

This broke compilation on Gentoo Linux. I have filed a downstream bug report regarding this:

https://bugs.gentoo.org/671900

CMake Error at CMakeLists.txt:565 (add_subdirectory):             
  add_subdirectory given source "Externals/minizip" which is not an existing
  directory. 

The failure occurs because Gentoo removes bundled libraries unless they are explicitly whitelisted. If it is not too much trouble, it would be appreciated if people would ping the Gentoo maintainer about new bundled libraries.

@delroth
Copy link
Member

delroth commented Nov 25, 2018

I'm sorry, are you complaining that Dolphin doesn't build when you randomly go and delete directories from our source code? Yeah, that tends to happen.

Whoever maintains the package for your distro is relying on assumptions that we never claimed to guarantee. We can't go and increase our workload for every single distro that goes and unilaterally decides to rely on implementation details. Especially not in our git master branch.

@riking
Copy link
Contributor

riking commented Nov 26, 2018

@ryao - The Gentoo code is also assuming that any library that Dolphin adds will never be the same as the name of a folder in the repository root: https://gitweb.gentoo.org/repo/gentoo.git/tree/games-emulation/dolphin/dolphin-9999.ebuild?id=2f26b496e55dddef5d8fce650becb4c3db4cc450#n95

This seems like a similarly bad assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants