Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/Settings: Add Cancel button to USB passthrough device dialog #7472

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

Z1ni
Copy link
Contributor

@Z1ni Z1ni commented Oct 8, 2018

@MayImilae
Copy link
Contributor

This is fairly straightforward but, screenshot please!

@Z1ni
Copy link
Contributor Author

Z1ni commented Oct 8, 2018

I noticed that I wrote Close on the button 😄
I'll change it to Cancel, as it should be.

@Z1ni Z1ni force-pushed the usb-dev-dialog-close branch from b0e50a1 to e1f0346 Compare October 8, 2018 22:46
@Helios747
Copy link
Contributor

@dolphin-emu-bot rebuild

@Helios747
Copy link
Contributor

Please setup and run clang-format (Which can be installed by installing LLVM) as documented here

https://github.com/dolphin-emu/dolphin/blob/master/Contributing.md#intro-aims

Once you pass linter I see no reason to keep this PR waiting

@Z1ni Z1ni force-pushed the usb-dev-dialog-close branch from e1f0346 to b27c688 Compare October 9, 2018 12:29
@Tilka Tilka merged commit 94f07e7 into dolphin-emu:master Oct 12, 2018
@ghost
Copy link

ghost commented Oct 12, 2018

Actually I was just about to mention, forgot whole day, including @BhaaLseN also raised this today, if that button should say "Close" rather than "Cancel". It's been 5 months since I created the bug ticket and I'm not sure I really meant "Cancel", if I did then I forgot the thought process for that specific reason.

@Z1ni
Copy link
Contributor Author

Z1ni commented Oct 12, 2018

"Cancel" seems good to me, as the user cancels the addition of a new USB device. "Close" does not necessarily imply that.
But that's just my two cents.

@ghost
Copy link

ghost commented Oct 12, 2018

Yes that's indeed correct in a way, I was just about to say, it may not be that of a big deal ofcourse, just raising the consistency thing.

However here's a stronger point after I did more thinking, "Cancel" would have to actually remove any of those devices from the whitelist .. (which isn't visible on this dialog, this list is showing all the available ones to select - @BhaaLseN) .. that were added while the dialog was open, IMHO.

@Tilka
Copy link
Member

Tilka commented Oct 12, 2018

I like how it is now.

@Z1ni Z1ni deleted the usb-dev-dialog-close branch October 12, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants