-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/Settings: Add Cancel button to USB passthrough device dialog #7472
Conversation
This is fairly straightforward but, screenshot please! |
I noticed that I wrote Close on the button 😄 |
b0e50a1
to
e1f0346
Compare
@dolphin-emu-bot rebuild |
Please setup and run clang-format (Which can be installed by installing LLVM) as documented here https://github.com/dolphin-emu/dolphin/blob/master/Contributing.md#intro-aims Once you pass linter I see no reason to keep this PR waiting |
e1f0346
to
b27c688
Compare
Actually I was just about to mention, forgot whole day, including @BhaaLseN also raised this today, if that button should say "Close" rather than "Cancel". It's been 5 months since I created the bug ticket and I'm not sure I really meant "Cancel", if I did then I forgot the thought process for that specific reason. |
"Cancel" seems good to me, as the user cancels the addition of a new USB device. "Close" does not necessarily imply that. |
Yes that's indeed correct in a way, I was just about to say, it may not be that of a big deal ofcourse, just raising the consistency thing. However here's a stronger point after I did more thinking, "Cancel" would have to actually remove any of those devices from the whitelist .. (which isn't visible on this dialog, this list is showing all the available ones to select - @BhaaLseN) .. that were added while the dialog was open, IMHO. |
I like how it is now. |
https://bugs.dolphin-emu.org/issues/11125