Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Minor changes #7223

Merged
merged 4 commits into from
Jul 12, 2018
Merged

CMakeLists: Minor changes #7223

merged 4 commits into from
Jul 12, 2018

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Jul 6, 2018

Just a few minor cleanup-related changes

lioncash added 4 commits July 6, 2018 13:13
The general convention for CMake is to use lowercase for commands, and
given we also follow that convention through most CMake files, this just
makes it more consistent.
The documentation for setting cache entries dicates that the type must
either be BOOL, FILEPATH, PATH, STRING, or INTERNAL (with those exact
casings). Also, given we properly case it in other places, this is just
consistent.
While we're in the same area, amend the newlining of the if block
We use spaces everywhere else in the CMake scripts, so this just makes
indentation consistent.
@degasus degasus merged commit 196bf8d into dolphin-emu:master Jul 12, 2018
@lioncash lioncash deleted the cmake branch July 12, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants