Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NetPlay using some config values wrongly #7221

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Fix NetPlay using some config values wrongly #7221

merged 1 commit into from
Jul 6, 2018

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Jul 5, 2018

Setup dialog used port from host tab for connecting, and stored IP address in the same config as host code.

spycrab
spycrab approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@spycrab spycrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codewise.

@spycrab spycrab merged commit 059880b into dolphin-emu:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spycrab spycrab spycrab approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techjar @spycrab