Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the capitalization of "GameCube" throughout the project. #470

Merged
merged 1 commit into from
Jun 13, 2014

Conversation

pauldacheez
Copy link
Contributor

This was done semi-blindly and touches translation-related files as well as comments and documentation that users don't see and therefore doesn't really need to be touched. Honestly, if the extra unnecessary stuff helps to ingrain the correct capitalization in everyone's minds, I'd prefer to keep it, but I'll get rid of it if you guys complain enough.

@lioncash
Copy link
Member

lioncash commented Jun 7, 2014

For the .po files, I believe only the English one needs to be modified. The others will synchronize with it whenever a transifex sync is done.

@pauldacheez
Copy link
Contributor Author

Well, doing it early won't break anything, will it?

@delroth
Copy link
Member

delroth commented Jun 8, 2014

Modifying the .po files is useless, the next sync from transifex will remove your changes.

@pauldacheez
Copy link
Contributor Author

I've removed the .po changes, then. Any other comments/requests?

@neobrain
Copy link
Member

@dolphin-emu-bot rebuild

neobrain added a commit that referenced this pull request Jun 13, 2014
Fix the capitalization of "GameCube" throughout the project.
@neobrain neobrain merged commit a8f32ad into dolphin-emu:master Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants