Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WbfsBlob: Don't enter an infinite loop when reading beyond end of disc #2712

Merged
merged 1 commit into from
Jul 12, 2015
Merged

WbfsBlob: Don't enter an infinite loop when reading beyond end of disc #2712

merged 1 commit into from
Jul 12, 2015

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Jul 6, 2015

read_size remained 0 when the "Read beyond end of disc" error occurs, which made the while (nbytes) loop never end. As a fix, SeekToCluster now explicitly sets available to 0 when the error occurs, and Read checks for it.

@JosJuice
WbfsBlob: Don't enter an infinite loop when reading beyond end of disc
9018b54 
read_size remained 0 when the "Read beyond end of disc" error occurs,
which made the while (nbytes) loop never end. As a fix, SeekToCluster
now explicitly sets available to 0 when the error occurs, and Read
checks for it.
@phire
Copy link
Member

phire commented Jul 7, 2015

LGTM

skidau added a commit that referenced this pull request Jul 12, 2015
@skidau
Merge pull request #2712 from JosJuice/wbfs-beyond-end-of-disc
cc79334 
WbfsBlob: Don't enter an infinite loop when reading beyond end of disc
@skidau skidau merged commit cc79334 into dolphin-emu:stable Jul 12, 2015
@JosJuice JosJuice deleted the wbfs-beyond-end-of-disc branch July 12, 2015 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JosJuice @phire @skidau