Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(torii): member clause escaped table name #2255

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix(torii): member clause escaped table name #2255

merged 1 commit into from
Aug 5, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Aug 2, 2024 •
edited by coderabbitai bot
Loading

Escapes the table name (breaks due to namespaces) when querying with member clause

Summary by CodeRabbit

  • Bug Fixes
    • Improved SQL query formatting to prevent potential issues with reserved words or special characters in table names.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 2, 2024 •
edited
Loading

Walkthrough

Ohayo, sensei! The recent changes focus on improving the SQL query string formatting in the DojoWorld implementation. Specifically, the table name is now enclosed in square brackets to enhance clarity and ensure compatibility with SQL syntax, particularly regarding reserved words or special characters. This adjustment maintains the overall logic and functionality of the code while addressing potential issues in query execution.

Changes

Files Change Summary
crates/torii/grpc/src/server/mod.rs Modified the SQL-like query string to wrap table_name in square brackets for improved syntax clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DojoWorld
    participant Database

    User->>DojoWorld: Execute query
    DojoWorld->>Database: Send query with [table_name]
    Database-->>DojoWorld: Return results
    DojoWorld-->>User: Display results
Loading
Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6480c82 and 4f2cfc5.

Files selected for processing (1)
  • crates/torii/grpc/src/server/mod.rs (1 hunks)
Additional comments not posted (1)
crates/torii/grpc/src/server/mod.rs (1)

519-519: Ohayo, sensei! Ensure compatibility with SQL syntax.

The change to wrap the table name in square brackets enhances compatibility with SQL syntax, particularly regarding reserved words or special characters in table names. This is a good practice to avoid potential SQL errors.

However, verify the usage of table names in other parts of the codebase to ensure consistency.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (6480c82) to head (4f2cfc5).

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2255   +/-   ##
=======================================
  Coverage   70.24%   70.24%           
=======================================
  Files         345      345           
  Lines       45455    45455           
=======================================
+ Hits        31930    31932    +2     
+ Misses      13525    13523    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 2b09547 into dojoengine:main Aug 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Larkooo @glihm