Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix and link German README (trivial) #3659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

doc: fix and link German README (trivial) #3659

wants to merge 1 commit into from

Conversation

patricklodder
Copy link
Member

  • fixes the language coding: it should be either de_DE or just de; the latter was chosen because there is only one German translation and can be used generically. See:
  • Added the translation to the internationalization index in doc/intl/README.md

@patricklodder patricklodder requested a review from a team October 3, 2024 11:02
FierceSkit
FierceSkit approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@FierceSkit FierceSkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
fine to me.
de_AT, de_CH & de_GER are pretty much the same in formally written language.

@patricklodder
Copy link
Member Author

de_AT, de_CH & de_GER are pretty much the same in formally written language.

de_DE !!! 😂 See: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

@FierceSkit
Copy link
Contributor

🤣
That was so fkin german, even the DIN should specify it as "Proof of Sauerkraut". 😂

@patricklodder
Copy link
Member Author

Sorry ser I identify as Rolex (de, CH)

@FierceSkit
Copy link
Contributor

gotcha. 👍
a swiss clock, eating schnitzel and wearing clogs with german tennis socks.
ultimate decentralization and diversity accomplished. xD

@thisiskeanyvy
Copy link
Contributor

I think it's a good idea to standardise READMEs, we already have that for the French version of README.

@thisiskeanyvy thisiskeanyvy mentioned this pull request Nov 27, 2024
Merged
@patricklodder
doc: fix and link German README
679fede 
- fixes the language coding: it should be either de_DE or just de;
  the latter was chosen because there is only one German
  translation and can be used generically. See RFC5646 for the
  scheme, ISO 639 for the language part and ISO 3166 for the
  territory part.
- Added the translation to the internationalizatio index in
  doc/intl/README.md
@patricklodder
Copy link
Member Author

rebased after #3715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGalapagos8 DGalapagos8 DGalapagos8 approved these changes

@FierceSkit FierceSkit FierceSkit approved these changes

@thisiskeanyvy thisiskeanyvy thisiskeanyvy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation
Projects
Review & merge board
Status: 🚀 needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patricklodder @FierceSkit @thisiskeanyvy @DGalapagos8