Backport Bitcoin's share/rpcauth/rpcauth.py in rpcuser.py #3388
Conversation
Anish-M-code
changed the title
share/rpcuser/rpcuser.py
Outdated
| print("String to be appended to dogecoin.conf") | ||
| print("rpcauth="+username+":"+salt+"$"+result) | ||
| print("Your password:\n"+password) | ||
| print('String to be appended to bitcoin.conf:') |
There was a problem hiding this comment.
Can you change this to dogecoin.conf? I think that's the only difference we want between these files. Thanks!
|
@chromatic I fixed as mentioned in the code review |
|
After deleting the rpc authentication Everything appears to be working, tested on Ubuntu 22.04. |
There was a problem hiding this comment.
Tested on arm64 macOS. Could use a squash, otherwise good to go.
@Anish-M-code do you want me to squash it for you?
|
@patricklodder , i would like if you could squash my pull request. can you please explain me how to squash commits in Github web UI or do you use git commandline to squash git commits. |
backport Bitcoin's share/rpcauth/rpcauth.py in rpcuser.py , no new functionalities like accepting password from user is not supported in this backport.
patricklodder
force-pushed
the
1.14.7_rpcuser_bitcoin_backport
branch
from
ea6b8b3 to
96778cf
Compare
Done!
This. But I will have a look at what options we have inside the GitHub web UI once we're done with the release |
|
@chromatic could you let us know if this is an acceptable implementation for your issue? |
|
Hey, any updates on this? |
|
This one is on my list next up, and I hope to get to it before the weekend. |
There was a problem hiding this comment.
ACK; this addresses my concerns. Thank you, @Anish-M-code ! I appreciate this.
I simply backported changes from Bitcoin to modernize rpcuser.py , no new functionalities were introduced. This Pull request aims to close feature request #3352