Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

fix(babel-plugin-export-metadata): fix hasOwnProperty method call #1581

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Oct 28, 2020

Fixes #1287 (when using export * as).

Demo:

const obj = Object.create(null)
console.info([
  // true
  Object.isExtensible(obj),
  // false
  obj instanceof Object,
  // TypeError: obj.hasOwnProperty is not a function
  // obj.hasOwnProperty('key'),
  // false
  Object.prototype.hasOwnProperty.call(bar, 'key'),
])

Object.defineProperty(obj, 'key', {value: 1})
// true
console.info(Object.prototype.hasOwnProperty.call(obj, 'key'))

@ambar ambar changed the title fix(babel-plugin-export-metadata): fix hasOwnProperty mehtod call fix(babel-plugin-export-metadata): fix hasOwnProperty method call Oct 28, 2020
@ambar
Copy link
Contributor Author

ambar commented Dec 23, 2020

@pedronauck

@pedronauck pedronauck merged commit 9067ffb into doczjs:main Jun 3, 2021
@pedronauck
Copy link
Member

thanks @ambar 🙏🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Build if I use "import * as xxxx"
2 participants