This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
fix(docz-core): forward cli status code properly #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very helpful ! Thanks 😄 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, spawned processes (for example,
gatsby build) run through CLI don't forward error code correctly to the parent process (docz build) producing success code (eg.0) even if some child processes failed.It can be problematic especially if we rely on it to do some CI/CD (like building a Docker image).
This PR solves the issue by forwarding properly child error code on
buildandservecommands.Screenshots
See
echo $?output.