-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add translations #1485
chore: add translations #1485
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThe pull request includes extensive updates to localization files for the Documenso application, specifically targeting German, Spanish, French, and Polish translations. Changes consist of adding new translation strings, modifying existing ones for clarity and accuracy, and removing outdated entries. The updates cover various aspects of the application, including document management actions, user notifications, and marketing messages. Metadata such as revision dates has also been updated across several files, ensuring that the translations reflect the latest content and context. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you for following the naming conventions for pull request titles! 💚🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (12)
packages/lib/translations/es/marketing.po (1)
Line range hint
21-605
: LGTM! Translations are accurate and well-formatted.The Spanish translations:
- Maintain the original meaning and context
- Preserve all placeholders and HTML tags
- Use proper Spanish grammar and punctuation
- Follow consistent terminology
Consider these minor refinements for better clarity:
- "Bandeja de entrada del equipo" → "Bandeja de entrada grupal" (more commonly used in Spanish software UIs)
- "Construir sobre." → "Construye sobre esto." (more natural in Spanish)
- "Startup Abierta" → "Empresa Emergente Abierta" (more formal translation)
packages/lib/translations/fr/marketing.po (4)
Line range hint
103-104
: Consider revising the translation for better clarity.The translation "Aucune carte de crédit requise" appears twice with different casing. Consider standardizing to maintain consistency.
-msgstr "Aucune carte de crédit requise" +msgstr "Aucune carte de crédit requise."
Line range hint
191-192
: Fix apostrophe usage in French translation.The translation uses a straight apostrophe in "PR's". In French, typographic apostrophes should be used.
-msgstr "PRs fusionnées" +msgstr "PRs fusionnées"
Line range hint
267-268
: Maintain consistent capitalization in translations.The translation "Total des clients" should maintain consistent capitalization with other similar translations in the file.
-msgstr "Total des clients" +msgstr "Total des Clients"
Line range hint
293-294
: Improve translation fluency.The current translation could be more natural in French.
-msgstr "Cette page évolue à mesure que nous apprenons ce qui fait une grande entreprise de signature. Nous la mettrons à jour lorsque nous aurons plus à partager." +msgstr "Cette page évolue au fur et à mesure que nous découvrons ce qui fait une excellente entreprise de signature. Nous la mettrons à jour dès que nous aurons plus d'informations à partager."packages/lib/translations/pl/common.po (3)
Line range hint
19-24
: Standardize quotation marks in translationsThe translations use a mix of different quotation marks („", "", '') which should be standardized for consistency. In Polish, the recommended format is „text".
Apply this standardization:
-msgstr "\"{documentName}\" został usunięty przez administratora." +msgstr "„{documentName}" został usunięty przez administratora." -msgstr "„{documentName}" został podpisany" +msgstr "„{documentName}" został podpisany" -msgstr "'{documentName}'" +msgstr "„{documentName}""
Line range hint
33-38
: Improve translation structure for better readabilityThe current translation structure could be improved to better match Polish language patterns.
Apply this improvement:
-msgstr "{0} zaprosił cię do {recipientActionVerb} dokument „{1}"." +msgstr "{0} zaprosił Cię do {recipientActionVerb} dokumentu „{1}"."
Line range hint
290-295
: Fix grammatical case in Polish translationThe translation uses incorrect grammatical case for the object.
Apply this grammatical fix:
-msgstr "Dokument został utworzony przez Twój bezpośredni szablon, który wymaga, abyś go {recipientActionVerb}." +msgstr "Został utworzony dokument z Twojego bezpośredniego szablonu, który wymaga {recipientActionVerb}."packages/lib/translations/fr/common.po (1)
Line range hint
1-1811
: Standardize quotation marks and placeholder spacingThere are inconsistencies in the use of quotation marks and spacing around placeholders throughout the translations:
- Some translations use straight quotes (
"
) while others use curly quotes (""
), e.g.:
"{documentName}" a été supprimé
vs."{documentName}" a été supprimé
- Some translations have inconsistent spacing around placeholders, e.g.:
{0}a rejoint
vs.{0} a rejoint
Consider standardizing:
- Use straight quotes (
"
) consistently throughout the translations- Always use a space after placeholders when followed by text
packages/lib/translations/es/common.po (1)
Line range hint
17-1810
: Maintain consistent capitalization in translationsWhile most translations maintain proper capitalization, there are some inconsistencies in button and action text capitalization. Consider standardizing the capitalization rules across all UI elements.
packages/lib/translations/de/common.po (2)
Line range hint
66-68
: Remove commented out translationsThere are commented out translations that should be removed as they are no longer needed.
-#~ msgid "APPROVE_REQUEST" -#~ msgstr "APPROVE_REQUEST" -#~ msgid "SIGNING_REQUEST" -#~ msgstr "SIGNING_REQUEST"Also applies to: 70-72
Line range hint
141-143
: Remove additional commented out translationsMore commented out translations that should be cleaned up.
-#~ msgid "A request to use your email has been initiated by {teamName} on Documenso" -#~ msgstr "A request to use your email has been initiated by {teamName} on Documenso" -#~ msgid "Document Rejection Confirmed" -#~ msgstr "Document Rejection Confirmed" -#~ msgid "Hello {recipientName}," -#~ msgstr "Hello {recipientName},"Also applies to: 472-474, 499-501
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(1 hunks)packages/lib/translations/de/marketing.po
(1 hunks)packages/lib/translations/de/web.po
(9 hunks)packages/lib/translations/es/common.po
(1 hunks)packages/lib/translations/es/marketing.po
(1 hunks)packages/lib/translations/es/web.po
(9 hunks)packages/lib/translations/fr/common.po
(1 hunks)packages/lib/translations/fr/marketing.po
(1 hunks)packages/lib/translations/fr/web.po
(9 hunks)packages/lib/translations/pl/common.po
(1 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(15 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/lib/translations/pl/marketing.po
🔇 Additional comments (24)
packages/lib/translations/es/marketing.po (1)
Line range hint 1-19
: LGTM! Header section is properly configured.
The PO file header contains all required metadata fields with correct values for Spanish localization.
packages/lib/translations/de/marketing.po (2)
Line range hint 20-605
: LGTM! Translations follow best practices.
The translations:
- Correctly preserve placeholders (e.g., {0})
- Maintain HTML tags (e.g., <0>, <1>)
- Use appropriate German language conventions
- Maintain consistent terminology throughout
Line range hint 1-19
: Verify the revision date in the metadata.
The PO-Revision-Date is set to November 14, 2024, which is ahead of the current date. This might cause issues with translation tooling.
✅ Verification successful
Future revision dates detected in translation files
All non-English translation files have revision dates set in November 2024, which is ahead of the current date:
- German, Spanish, and French files: November 14, 2024
- Polish files: November 20, 2024
- Only Romanian files have dates from July 2024
This appears to be a systematic pattern across multiple language files, likely due to the translation management system's (Crowdin) configuration. Since this is consistent across multiple files and languages, and given that translation systems often work with scheduled/future releases, this is likely intentional behavior rather than an error.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for other PO files with future dates
# Expected: No other files should have dates beyond the current date
# Find all .po files and check their PO-Revision-Date
fd -e po -x grep -l "PO-Revision-Date: 2024-11" {}
Length of output: 546
Script:
#!/bin/bash
# Let's check the actual content of these PO files to verify the exact dates
for file in $(fd -e po); do
echo "=== $file ==="
grep "PO-Revision-Date:" "$file"
done
# Also check the Git history to see when these files were last modified
echo -e "\nGit history:"
git log -p --since="2024-01-01" --grep="PO-Revision-Date" -- "*.po"
Length of output: 4246
packages/lib/translations/fr/marketing.po (2)
Line range hint 1-19
: LGTM! Header section is properly configured.
The PO file header contains all required metadata with correct settings for French localization.
Line range hint 20-605
: Overall translation quality is good.
The translations are generally accurate and maintain proper French grammar and terminology. The file includes all necessary strings and properly handles placeholders.
packages/lib/translations/pl/common.po (1)
11-11
: LGTM: Revision date is accurate
The PO-Revision-Date matches the date mentioned in the AI summary.
packages/lib/translations/fr/common.po (1)
Line range hint 1-24
: LGTM: Well-structured file metadata
The file metadata is well-structured with all necessary headers:
- Character encoding (UTF-8)
- Language specification (fr)
- Plural forms definition
- Project metadata
packages/lib/translations/es/common.po (4)
Line range hint 1-15
: LGTM: Metadata headers are correctly formatted
The PO file headers contain all required fields and are properly formatted with correct character encoding, language settings, and plural forms specification.
Line range hint 17-1810
: Excellent handling of placeholders and variables
The translations correctly maintain all placeholders (e.g., {0}, {documentName}, etc.) and HTML tags (e.g., <0>, </0>). This is crucial for proper string interpolation and formatting.
Line range hint 17-1810
: Verify gender-neutral language usage
The Spanish translations appropriately use gender-neutral language where possible. However, some terms might benefit from more inclusive alternatives. For example, "firmantes" could potentially be made more inclusive in some contexts.
✅ Verification successful
Based on the search results, I can now provide a final assessment of the gender-neutral language usage in the Spanish translations.
Gender-neutral language is appropriately used in the translations
The search results show that the Spanish translations in common.po
have been carefully crafted to use inclusive language where possible. For example:
- Using neutral terms like "destinatario" instead of gendered alternatives
- Using collective nouns like "equipo" that are inherently gender-neutral
- Employing passive voice constructions where appropriate to avoid gendered language
The few instances of gendered plurals (like "firmantes", "espectadores") follow Spanish language conventions where masculine plural forms serve as the gender-neutral default, which is currently accepted practice in formal Spanish documentation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for potentially gendered terms
echo "Checking for gendered terms..."
rg -i 'msgstr ".*\b(o|a)s\b.*"'
Length of output: 4269
Line range hint 17-1810
: Verify translation consistency for technical terms
The translations are generally good, but there are some technical terms that should be consistently translated throughout the file. For example:
- "sign" is sometimes translated as "firmar" and sometimes as "firma"
- "field" is consistently translated as "campo"
- "document" is consistently translated as "documento"
Consider maintaining a glossary of technical terms to ensure consistency across all translations.
✅ Verification successful
Based on the extensive search results, I can now verify the consistency of translations for key technical terms in the Spanish translations file:
Sign/Firma translations
- "sign" (verb) is consistently translated as "firmar"
- "signature" (noun) is consistently translated as "firma"
- "signing" (gerund) is consistently translated as "firmando"
- "signer" (noun) is consistently translated as "firmante"
Field/Campo translations
- "field" is consistently translated as "campo" across all contexts
- "field label" -> "etiqueta de campo"
- "field placeholder" -> "marcador de posición de campo"
- "field format" -> "formato de campo"
Document/Documento translations
- "document" is consistently translated as "documento" across all contexts
- "document title" -> "título del documento"
- "document status" -> "estado del documento"
- "document access" -> "acceso al documento"
The translations maintain good consistency for these key technical terms throughout the file. The Spanish translations appropriately use the standard technical vocabulary in Spanish for document signing and form fields.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for inconsistent translations of key technical terms
echo "Checking translation consistency for technical terms..."
# Check 'sign' translations
echo "Translations for 'sign':"
rg -i 'msgid ".*\bsign\b.*"' -A 1
# Check 'field' translations
echo "Translations for 'field':"
rg -i 'msgid ".*\bfield\b.*"' -A 1
# Check 'document' translations
echo "Translations for 'document':"
rg -i 'msgid ".*\bdocument\b.*"' -A 1
Length of output: 405727
packages/lib/translations/de/common.po (2)
Line range hint 1-15
: LGTM: File header is well-formed and complete
The PO file header contains all necessary metadata including:
- Creation date
- MIME settings
- Language information
- Project details
- Plural forms definition
Line range hint 1-1810
: Verify translation completeness
The translations appear to be comprehensive and well-structured. However, let's verify there are no missing translations.
✅ Verification successful
The search results show that the empty msgstr ""
entries found are only the header entries of various .po files, which is the standard format for PO files and not indicative of missing translations. Additionally, no fuzzy translations were found in the German translations file under review.
All translations in the German locale file are complete and properly formatted
The file packages/lib/translations/de/common.po contains all required translations with no untranslated strings or fuzzy translations. The only empty msgstr is in the PO file header which is expected and correct according to the gettext format specification.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any untranslated strings or fuzzy translations
# Look for empty msgstr entries
rg '^msgstr ""$' -A 1
# Look for fuzzy translations
rg '^#, fuzzy' -A 2
Length of output: 2490
packages/lib/translations/pl/web.po (2)
257-258
: LGTM! Translation accuracy improved
The change from "Autoryzacja" to "Uwierzytelnianie" is more accurate as it better reflects the technical meaning of "authentication" in Polish.
312-313
: LGTM! Translation accuracy improved
The changes to use "symbole zastępcze" and "odpowiednie" provide more precise and contextually appropriate translations.
packages/lib/translations/es/web.po (3)
Line range hint 1-52
: LGTM! Well-structured PO file header
The file header contains all required metadata and is properly formatted with correct language settings for Spanish.
53-61
: LGTM! Accurate translations for signing page view
The translations maintain the original meaning while using natural Spanish expressions. Placeholders like {0}
are correctly preserved.
Line range hint 751-5120
: LGTM! High quality translations with consistent terminology
The translations demonstrate several good practices:
- Consistent terminology across billing, authentication and document-related terms
- Proper handling of HTML tags and placeholders
- Natural Spanish expressions while maintaining the original meaning
- Correct handling of plural forms using the
plural
syntax
packages/lib/translations/fr/web.po (2)
53-61
: LGTM! The translations are accurate and consistent.
The new French translations for the signing page view are well-implemented and maintain proper grammar, tone and formality.
751-751
: LGTM! Correct standard translation used.
The translation of "Billing" to "Facturation" is accurate and follows common French UI terminology.
packages/lib/translations/de/web.po (4)
53-61
: LGTM! The signing page translations are accurate.
The translations maintain consistent terminology and formal tone while accurately conveying the meaning of the original messages.
751-751
: LGTM! The billing related translations are accurate.
The translations for billing related messages maintain consistency in terminology and formal tone while accurately conveying the meaning of the original messages.
Also applies to: 2253-2253, 4454-4454, 4787-4787, 4839-4839, 4985-4985
3334-3334
: LGTM! The error message translation is accurate.
The translation maintains the appropriate tone and meaning of the original error message.
5120-5120
: LGTM! Empty line at end of file.
Having an empty line at the end of PO files is standard practice.
@@ -1814,3 +1808,4 @@ msgstr "Votre mot de passe a été mis à jour." | |||
#: packages/email/templates/team-delete.tsx:32 | |||
msgid "Your team has been deleted" | |||
msgstr "Votre équipe a été supprimée" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove orphaned line number
There's an orphaned line number "1811" at the end of the file that should be removed.
Committable suggestion skipped: line range outside the PR's diff.
@@ -1814,3 +1808,4 @@ msgstr "Tu contraseña ha sido actualizada." | |||
#: packages/email/templates/team-delete.tsx:32 | |||
msgid "Your team has been deleted" | |||
msgstr "Tu equipo ha sido eliminado" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove orphaned line number
There's an orphaned line number at the end of the file that should be removed.
Committable suggestion skipped: line range outside the PR's diff.
@@ -1814,3 +1808,4 @@ msgstr "Dein Passwort wurde aktualisiert." | |||
#: packages/email/templates/team-delete.tsx:32 | |||
msgid "Your team has been deleted" | |||
msgstr "Dein Team wurde gelöscht" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove orphaned line number
There appears to be an orphaned line number at the end of the file that should be removed.
Committable suggestion skipped: line range outside the PR's diff.
dab1cf1
to
7bc450a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/lib/translations/fr/web.po (1)
4839-4839
: Improve translation fluidityThe current translation is technically correct but sounds unnatural in French. Consider using a more idiomatic phrasing:
-"Vous n'avez actuellement pas de dossier client, cela ne devrait pas se produire. Veuillez contacter le support pour obtenir de l'aide." +"Aucun dossier client n'a été trouvé pour votre compte, ce qui est anormal. Veuillez contacter le support pour obtenir de l'aide."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(1 hunks)packages/lib/translations/de/marketing.po
(1 hunks)packages/lib/translations/de/web.po
(9 hunks)packages/lib/translations/es/common.po
(1 hunks)packages/lib/translations/es/marketing.po
(1 hunks)packages/lib/translations/es/web.po
(9 hunks)packages/lib/translations/fr/common.po
(1 hunks)packages/lib/translations/fr/marketing.po
(1 hunks)packages/lib/translations/fr/web.po
(9 hunks)packages/lib/translations/pl/common.po
(1 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(15 hunks)
🚧 Files skipped from review as they are similar to previous changes (11)
- packages/lib/translations/de/common.po
- packages/lib/translations/de/marketing.po
- packages/lib/translations/de/web.po
- packages/lib/translations/es/common.po
- packages/lib/translations/es/marketing.po
- packages/lib/translations/es/web.po
- packages/lib/translations/fr/common.po
- packages/lib/translations/fr/marketing.po
- packages/lib/translations/pl/common.po
- packages/lib/translations/pl/marketing.po
- packages/lib/translations/pl/web.po
packages/lib/translations/fr/web.po
Outdated
#: apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx:79 | ||
msgid "({0}) has invited you to approve this document" | ||
msgstr "({0}) vous a invité à approuver ce document" | ||
|
||
#: apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx:77 | ||
#: apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx:76 | ||
msgid "({0}) has invited you to sign this document" | ||
msgstr "({0}) vous a invité à signer ce document" | ||
|
||
#: apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx:74 | ||
#: apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx:73 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Ensure consistent placeholder formatting
The translations add parentheses around the {0} placeholder while the English source text does not have them. This could cause inconsistent formatting in the UI. Consider removing the extra parentheses to match the source format:
-"({0}) vous a invité à approuver ce document"
+"${0} vous a invité à approuver ce document"
-"({0}) vous a invité à signer ce document"
+"${0} vous a invité à signer ce document"
-"({0}) vous a invité à consulter ce document"
+"${0} vous a invité à consulter ce document"
Committable suggestion skipped: line range outside the PR's diff.
7bc450a
to
97749fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
packages/lib/translations/fr/common.po (1)
Line range hint
1-1811
: Standardize French quotation marksFor better adherence to French typography standards, consider using French quotation marks (« ») consistently throughout the translations instead of mixing both styles (" and « »).
Examples of inconsistencies:
"{documentName}" a été supprimé par un admin."
could be« {documentName} » a été supprimé par un admin.
"Veuillez {0} votre document"
could be« Veuillez {0} votre document »
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(1 hunks)packages/lib/translations/de/marketing.po
(1 hunks)packages/lib/translations/de/web.po
(9 hunks)packages/lib/translations/es/common.po
(1 hunks)packages/lib/translations/es/marketing.po
(1 hunks)packages/lib/translations/es/web.po
(9 hunks)packages/lib/translations/fr/common.po
(1 hunks)packages/lib/translations/fr/marketing.po
(1 hunks)packages/lib/translations/fr/web.po
(9 hunks)packages/lib/translations/pl/common.po
(1 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(15 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/lib/translations/de/common.po
- packages/lib/translations/de/marketing.po
- packages/lib/translations/de/web.po
- packages/lib/translations/es/common.po
- packages/lib/translations/es/marketing.po
- packages/lib/translations/es/web.po
- packages/lib/translations/fr/marketing.po
- packages/lib/translations/pl/common.po
- packages/lib/translations/pl/marketing.po
🔇 Additional comments (6)
packages/lib/translations/fr/common.po (2)
1811-1811
: Remove orphaned line number
The orphaned line number "1811" at the end of the file should be removed.
Line range hint 1-15
: LGTM: PO file structure is correct
The file follows proper PO file conventions with correct headers, metadata, and plural forms specification.
packages/lib/translations/pl/web.po (1)
257-258
: LGTM! Translations are accurate and clear
The translations are:
- Grammatically correct
- Use appropriate terminology
- Maintain consistent style
Also applies to: 312-313, 362-363
packages/lib/translations/fr/web.po (3)
751-753
: LGTM!
The translation "Facturation" is accurate and consistent with standard French UI terminology.
2253-2254
: LGTM!
The translation "Gérer l'abonnement" is accurate and maintains consistent terminology.
Line range hint 4454-5120
: LGTM!
The translations maintain consistency in terminology and tone while properly handling placeholders and HTML tags.
msgstr "Dodaj hasło" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect translation of "passkey"
"Passkey" should not be translated as "hasło" (password) as these are different concepts. Use "klucz dostępu" instead.
-msgstr "Dodaj hasło"
+msgstr "Dodaj klucz dostępu"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
msgstr "Dodaj hasło" | |
msgstr "Dodaj klucz dostępu" | |
msgstr "Ponowna Autoryzacja Konta" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent translation and capitalization
The translation should:
- Use "Uwierzytelnianie" instead of "Autoryzacja" for consistency with other translations
- Follow Polish capitalization rules (only first word capitalized)
-msgstr "Ponowna Autoryzacja Konta"
+msgstr "Ponowne uwierzytelnianie konta"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
msgstr "Ponowna Autoryzacja Konta" | |
msgstr "Ponowne uwierzytelnianie konta" |
97749fe
to
bd8dda1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
packages/lib/translations/fr/common.po (1)
Line range hint
1-1811
: Standardize quotation marks and formalityThe translations use a mix of straight quotes (") and French quotes (« »). Consider standardizing to French quotes for better localization. Also, ensure consistent use of formal address forms throughout the translations.
Examples to update:
-msgstr "\"{documentName}\" a été supprimé par un admin." +msgstr "« {documentName} » a été supprimé par un admin." -msgstr ""{documentName}" a été signé par tous les signataires" +msgstr "« {documentName} » a été signé par tous les signataires"packages/lib/translations/fr/web.po (1)
Line range hint
10-10
: Fix the future revision date in metadataThe PO-Revision-Date is set to "2024-11-14" which is in the future. This could cause issues with translation tools and version tracking.
Apply this diff to fix the date:
-"PO-Revision-Date: 2024-11-14 12:05\n" +"PO-Revision-Date: 2023-11-14 12:05\n"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(1 hunks)packages/lib/translations/de/marketing.po
(1 hunks)packages/lib/translations/de/web.po
(9 hunks)packages/lib/translations/es/common.po
(1 hunks)packages/lib/translations/es/marketing.po
(1 hunks)packages/lib/translations/es/web.po
(9 hunks)packages/lib/translations/fr/common.po
(1 hunks)packages/lib/translations/fr/marketing.po
(1 hunks)packages/lib/translations/fr/web.po
(9 hunks)packages/lib/translations/pl/common.po
(1 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(15 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/lib/translations/de/common.po
- packages/lib/translations/de/marketing.po
- packages/lib/translations/es/common.po
- packages/lib/translations/es/marketing.po
- packages/lib/translations/es/web.po
- packages/lib/translations/fr/marketing.po
- packages/lib/translations/pl/common.po
- packages/lib/translations/pl/marketing.po
- packages/lib/translations/pl/web.po
🔇 Additional comments (6)
packages/lib/translations/fr/common.po (2)
Line range hint 1-15
: LGTM: PO file structure is correct
The file follows proper PO file format with correct headers, metadata, and plural forms definition.
1811-1811
:
Remove orphaned line number
The line "1811~" at the end of the file should be removed as it serves no purpose and could potentially cause parsing issues.
Likely invalid or redundant comment.
packages/lib/translations/fr/web.po (1)
53-61
: Placeholder formatting inconsistency noted in previous review
The inconsistent placeholder formatting issue identified in the previous review is still present. Skipping duplicate comment.
packages/lib/translations/de/web.po (3)
53-61
: LGTM! Translations for signing page view messages are accurate and natural
The German translations for the signing page view messages accurately convey the meaning while maintaining natural German language flow. The translations properly handle placeholders and maintain consistent terminology.
751-751
: LGTM! Translation for "Billing" is accurate
The German translation "Abrechnung" for "Billing" is the standard and appropriate term used in German business context.
2253-2253
: LGTM! Billing and subscription related translations are consistent
The German translations for billing and subscription related messages maintain consistency in terminology and accurately convey the meaning. The translations properly handle:
- Error messages
- Subscription status notifications
- Billing portal messages
Also applies to: 3334-3334, 4454-4454, 4787-4787, 4839-4839, 4985-4985, 5120-5120
bd8dda1
to
45ea2c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
packages/lib/translations/fr/common.po (2)
Line range hint
33-33
: Improve quotation mark consistencyFrench typography traditionally uses « » (guillemets) for quotations. Consider updating the following translations for better consistency with French conventions:
-"\"{documentName}\" a été supprimé par un admin." +« {documentName} » a été supprimé par un admin."Also applies to: 34-34
Line range hint
1095-1095
: Fix spacing in French translationThe French translation is missing a space after "est" in "votre document eststrictement".
-"Soyez assuré, votre document eststrictement confidentiel et ne sera jamais partagé. Seule votre expérience de signature sera mise en avant. Partagez votre carte de signature personnalisée pour mettre en valeur votre signature !" +"Soyez assuré, votre document est strictement confidentiel et ne sera jamais partagé. Seule votre expérience de signature sera mise en avant. Partagez votre carte de signature personnalisée pour mettre en valeur votre signature !"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(1 hunks)packages/lib/translations/de/marketing.po
(1 hunks)packages/lib/translations/de/web.po
(9 hunks)packages/lib/translations/es/common.po
(1 hunks)packages/lib/translations/es/marketing.po
(1 hunks)packages/lib/translations/es/web.po
(9 hunks)packages/lib/translations/fr/common.po
(1 hunks)packages/lib/translations/fr/marketing.po
(1 hunks)packages/lib/translations/fr/web.po
(9 hunks)packages/lib/translations/pl/common.po
(1 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(15 hunks)
🚧 Files skipped from review as they are similar to previous changes (11)
- packages/lib/translations/de/common.po
- packages/lib/translations/de/marketing.po
- packages/lib/translations/de/web.po
- packages/lib/translations/es/common.po
- packages/lib/translations/es/marketing.po
- packages/lib/translations/es/web.po
- packages/lib/translations/fr/marketing.po
- packages/lib/translations/fr/web.po
- packages/lib/translations/pl/common.po
- packages/lib/translations/pl/marketing.po
- packages/lib/translations/pl/web.po
🔇 Additional comments (1)
packages/lib/translations/fr/common.po (1)
1811-1811
:
Remove orphaned line number
There's an orphaned line number "1811" at the end of the file that should be removed.
Likely invalid or redundant comment.
45ea2c8
to
39bd447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
packages/lib/translations/fr/common.po (3)
Line range hint
1090-1090
: Consider refining the French translation for better clarityThe current translation could be more natural in French.
-msgstr "Ce destinataire ne peut plus être modifié car il a signé un champ ou complété le document." +msgstr "Ce destinataire ne peut plus être modifié car il a déjà signé un champ ou finalisé le document."
Line range hint
205-205
: Enhance translation precisionThe French translation could be more precise and professional.
-msgstr "Nous n'enverrons rien pour notifier les destinataires." +msgstr "Aucune notification ne sera envoyée aux destinataires."
Line range hint
37-37
: Standardize quotation mark usageThere's inconsistent use of quotation marks across translations. Some use straight quotes (") while others use French quotes (« »).
Consider standardizing to French quotes with proper spacing. For example:
-msgstr "« {documentName} » a été signé" +msgstr "« {documentName} » a été signé" -msgstr ""{documentName}" a été signé par tous les signataires" +msgstr "« {documentName} » a été signé par tous les signataires"Also applies to: 41-41, 42-42
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(1 hunks)packages/lib/translations/de/marketing.po
(1 hunks)packages/lib/translations/de/web.po
(9 hunks)packages/lib/translations/es/common.po
(1 hunks)packages/lib/translations/es/marketing.po
(1 hunks)packages/lib/translations/es/web.po
(9 hunks)packages/lib/translations/fr/common.po
(1 hunks)packages/lib/translations/fr/marketing.po
(1 hunks)packages/lib/translations/fr/web.po
(9 hunks)packages/lib/translations/pl/common.po
(1 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(15 hunks)
🚧 Files skipped from review as they are similar to previous changes (10)
- packages/lib/translations/de/common.po
- packages/lib/translations/de/marketing.po
- packages/lib/translations/de/web.po
- packages/lib/translations/es/common.po
- packages/lib/translations/es/marketing.po
- packages/lib/translations/es/web.po
- packages/lib/translations/fr/marketing.po
- packages/lib/translations/fr/web.po
- packages/lib/translations/pl/common.po
- packages/lib/translations/pl/marketing.po
🔇 Additional comments (2)
packages/lib/translations/pl/web.po (2)
266-267
: Fix inconsistent translation and capitalization
The translation should:
- Use "Uwierzytelnianie" instead of "Autoryzacja" for consistency with other translations
- Follow Polish capitalization rules (only first word capitalized)
-msgstr "Ponowna Autoryzacja Konta"
+msgstr "Ponowne uwierzytelnianie konta"
338-339
: Fix incorrect translation of "passkey"
"Passkey" should not be translated as "hasło" (password) as these are different concepts. Use "klucz dostępu" instead.
-msgstr "Dodaj hasło"
+msgstr "Dodaj klucz dostępu"
39bd447
to
27bbc80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
packages/lib/translations/de/common.po
(3 hunks)packages/lib/translations/de/marketing.po
(2 hunks)packages/lib/translations/de/web.po
(7 hunks)packages/lib/translations/es/common.po
(3 hunks)packages/lib/translations/es/marketing.po
(2 hunks)packages/lib/translations/es/web.po
(7 hunks)packages/lib/translations/fr/common.po
(3 hunks)packages/lib/translations/fr/marketing.po
(2 hunks)packages/lib/translations/fr/web.po
(7 hunks)packages/lib/translations/pl/common.po
(24 hunks)packages/lib/translations/pl/marketing.po
(1 hunks)packages/lib/translations/pl/web.po
(36 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
- packages/lib/translations/de/common.po
- packages/lib/translations/de/marketing.po
- packages/lib/translations/es/common.po
- packages/lib/translations/es/marketing.po
- packages/lib/translations/es/web.po
- packages/lib/translations/fr/marketing.po
- packages/lib/translations/pl/common.po
- packages/lib/translations/pl/marketing.po
🔇 Additional comments (6)
packages/lib/translations/fr/common.po (3)
11-11
: LGTM: Revision date updated
The PO revision date has been correctly updated to reflect recent changes.
555-555
: LGTM: Accurate French translation for Checkbox
The translation "Case à cocher" is the correct and commonly used French term for "Checkbox" in user interfaces.
1817-1817
: Remove orphaned line number
There's an orphaned line number "1817" at the end of the file that should be removed.
packages/lib/translations/fr/web.po (1)
487-487
: LGTM! The translations are accurate and natural.
The French translations maintain the original meaning while using natural language constructs. The error messages and instructions are clear and well-formatted.
Also applies to: 2249-2249, 4739-4739, 5143-5143
packages/lib/translations/de/web.po (2)
487-487
: LGTM! Clear and accurate translation of the auto-signing error message
The German translation effectively communicates the error scenario and provides clear instructions to the user.
2249-2249
: LGTM! Concise translation of "Manage billing"
"Rechnungsmanagement" is an accurate and natural German translation that maintains the meaning of the original text.
@@ -335,7 +343,7 @@ msgstr "Dodaj więcej" | |||
#: apps/web/src/app/(dashboard)/settings/security/passkeys/create-passkey-dialog.tsx:146 | |||
#: apps/web/src/app/(dashboard)/settings/security/passkeys/create-passkey-dialog.tsx:154 | |||
msgid "Add passkey" | |||
msgstr "Dodaj klucz hasła" | |||
msgstr "Dodaj hasło" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect translation of "passkey"
"Passkey" should not be translated as "hasło" (password) as these are different concepts. Use "klucz dostępu" instead.
-msgstr "Dodaj hasło"
+msgstr "Dodaj klucz dostępu"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
msgstr "Dodaj hasło" | |
msgstr "Dodaj klucz dostępu" |
@@ -263,7 +271,7 @@ msgstr "Konto usunięte" | |||
|
|||
#: apps/web/src/app/(internal)/%5F%5Fhtmltopdf/certificate/page.tsx:119 | |||
msgid "Account Re-Authentication" | |||
msgstr "Ponowna autoryzacja konta" | |||
msgstr "Ponowna Autoryzacja Konta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent translation and capitalization
The translation should:
- Use "Uwierzytelnianie" instead of "Autoryzacja" for consistency with other translations
- Follow Polish capitalization rules (only first word capitalized)
-msgstr "Ponowna Autoryzacja Konta"
+msgstr "Ponowne uwierzytelnianie konta"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
msgstr "Ponowna Autoryzacja Konta" | |
msgstr "Ponowne uwierzytelnianie konta" |
Summary by CodeRabbit
Release Notes
New Features
Improvements
Chores