-
Notifications
You must be signed in to change notification settings - Fork 19
Add conflict on doctrine/common for <2.9@dev #10
Conversation
The build failure is obvious, there is no 2.9.0 now. :) So we either need 2.9@dev in require-dev or wait... |
Merging this anyway, as we can't release without this conflict, and |
@Majkl578 |
It was forgotten in 1.0.0 so it should be considered a bugfix. Otherwise there may be weird composer errors with optimized autoloader (ambiguous class resolution with Common 2.8 + this package). :/ |
@Majkl578 the problem is that this kind of approach makes Annoying, but I understand that this was forgotten: happens. |
Yup, suggestions? :) I don't feel like retag would be a cool solution. So at least reflection is not a package that is usually used without persistence so conflict in persistence should hold installation back. |
Tagging |
Not sure, we are in a deadlock right now. :) Common 2.9 will need ^1.0.1 and 1.0.1 here needs Common 2.9 (require-dev). |
Then we can just do 2 releases. Release 1.0.1 here now. Update common to 1.0.1, then release 1.0.2 to reference common 2.9 |
No description provided.