Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Add conflict on doctrine/common for <2.9@dev #10

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Conversation

jwage
Copy link
Member

@jwage jwage commented Jun 14, 2018

No description provided.

@jwage jwage added this to the 1.0.1 milestone Jun 14, 2018
@jwage jwage self-assigned this Jun 14, 2018
@Majkl578
Copy link
Contributor

The build failure is obvious, there is no 2.9.0 now. :) So we either need 2.9@dev in require-dev or wait...

@Ocramius
Copy link
Member

Merging this anyway, as we can't release without this conflict, and doctrine/common releasing will happen after this release anyway.

@Ocramius Ocramius merged commit d1db8ce into master Jun 15, 2018
@Ocramius Ocramius deleted the add-common-conflict branch June 15, 2018 07:55
@Ocramius
Copy link
Member

@Majkl578 1.0.1 the correct target release? Since we are changing dependencies, this should probably be 1.1.0

@Majkl578
Copy link
Contributor

It was forgotten in 1.0.0 so it should be considered a bugfix. Otherwise there may be weird composer errors with optimized autoloader (ambiguous class resolution with Common 2.8 + this package). :/

@Ocramius
Copy link
Member

@Majkl578 the problem is that this kind of approach makes 1.0.0 installable (and a fallback), which means many tricky scenarios where the SAT fails everywhere but for 1.0.0, and it will install 1.0.0 even if newer versions are available.

Annoying, but I understand that this was forgotten: happens.

@Majkl578
Copy link
Contributor

Yup, suggestions? :) I don't feel like retag would be a cool solution. So at least reflection is not a package that is usually used without persistence so conflict in persistence should hold installation back.

@Ocramius
Copy link
Member

Tagging 1.0.1 and making sure nothing else uses 1.0.0 is a decent mitigation. This means there's no released doctrine/common version pointing at 1.0.0

@jwage
Copy link
Member Author

jwage commented Jun 15, 2018

@Ocramius @Majkl578 want me to go ahead and tag 1.0.1 of doctrine/reflection?

@Majkl578
Copy link
Contributor

Not sure, we are in a deadlock right now. :) Common 2.9 will need ^1.0.1 and 1.0.1 here needs Common 2.9 (require-dev).

@jwage
Copy link
Member Author

jwage commented Jun 15, 2018

Then we can just do 2 releases. Release 1.0.1 here now. Update common to 1.0.1, then release 1.0.2 to reference common 2.9

@alcaeus alcaeus modified the milestones: 1.0.1, 1.1.0 Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants