Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async core and import-once example #36

Merged
merged 4 commits into from
Aug 12, 2015
Merged

Async core and import-once example #36

merged 4 commits into from
Aug 12, 2015

Conversation

nfriedly
Copy link
Contributor

Makes codebase fully async, and also adds an example to the readme for working with the import-once module.

Note: this is branched off of my earlier PR (#34) because I believe that there would be conflicts otherwise. However, I'm targeting develop with this PR.

Fixes #35

10xLaCroixDrinker
10xLaCroixDrinker reviewed Aug 12, 2015
View reviewed changes
package.json
@@ -25,7 +25,8 @@
"Jimmy King <hello@jimmyking.me> (https://github.com/jking90)",
"Jan Kolkmeier <jankolkmeier@gmail.com> (https://github.com/jouz)",
"Benjamin Lupton <b@lupton.cc> (https://github.com/balupton)",
"Johannes Troeger (https://github.com/johannestroeger)"
"Johannes Troeger (https://github.com/johannestroeger)",
"Nathan Friedly (http://nfriedly.com/)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are alphabetical by last name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, one sec

10xLaCroixDrinker added a commit that referenced this pull request Aug 12, 2015
@10xLaCroixDrinker
Merge pull request #36 from nfriedly/async-import-once
e89c2cd 
Async core and import-once example
@10xLaCroixDrinker 10xLaCroixDrinker merged commit e89c2cd into docpad:develop Aug 12, 2015
10xLaCroixDrinker pushed a commit that referenced this pull request Aug 12, 2015
Release v2.8.0
4100265 
  - Deprecated `bourbon` and `neat` options
  - Updated dependencies
  - Made async (#36, thanks @nfriedly)
@10xLaCroixDrinker
Copy link
Contributor

Published in v2.8.0

@nfriedly
Copy link
Contributor Author

Whoot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfriedly @10xLaCroixDrinker