Skip to content
This repository has been archived by the owner on Aug 6, 2022. It is now read-only.

Mac toolchain updates #406

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

acdha
Copy link
Contributor

@acdha acdha commented Dec 27, 2021

This has two minor changes to the build process on macOS which I encountered while working on #405:

This is required by the init_macos.sh script which had a separate error message in case this is missing.
This supports the now-standard /opt/homebrew prefix without breaking backwards compatibility on installs which predate that switch (most Intel Macs, for example).
@janhoy janhoy merged commit 085f2e1 into docker-solr:master Jan 4, 2022
@janhoy
Copy link
Contributor

janhoy commented Jan 4, 2022

Thanks for the nice contrib

twagoo pushed a commit to clarin-eric/docker-solr-clarin that referenced this pull request Jan 12, 2022
* Build (MacOS): Document the need for gnu-sed 
This is required by the init_macos.sh script which had a separate error message in case this is missing.
* init_macos.sh: support Homebrew prefixes

This supports the now-standard /opt/homebrew prefix without breaking backwards compatibility on installs which predate that switch (most Intel Macs, for example).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants