This repository has been archived by the owner on Aug 6, 2022. It is now read-only.
Fix race condition in wait-for-solr.sh #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script is failing to detect Solr instance as alive due to a race condition between two commands in a pipe. `grep -q` succeeds and exits early, causing the still-writing `wget` to fail to write its stdout to the pipe, and the overall pipeline to fail.
makuk66
suggested changes
May 8, 2020
There was a problem hiding this comment.
Looks good. Try running bash tools/update.sh; that should fill in the copies in the version directories for you, then you can add those to the PR too. (Today it shouldn't happen, but sometimes if you try that it discovers a new version and adds that, which should be a separate PR anyway, and you typically want to leave to the maintainers).
|
@makuk66 Thank you, I ran the command and committed the result. |
makuk66
approved these changes
May 8, 2020
|
Great stuff -- thanks! |
janhoy
added a commit
to cominvent/docker-solr
that referenced
this pull request
May 10, 2020
janhoy
added a commit
that referenced
this pull request
May 10, 2020
ncreuschling
added a commit
to dkd/docker-solr
that referenced
this pull request
Oct 20, 2020
* 'master' of https://github.com/docker-solr/docker-solr: Upgrade to Solr 8.6.3 (docker-solr#351) Bashbrew link changed Upgrading to 8.6.2 (docker-solr#344) Add a link to release docs Add Solr 8.6.1 Add Solr 8.6.0 (docker-solr#336) Add github user for Apache Solr project Upgrade to 8.5.2 Remove misleading documentation about download server in Europe Added new key Add the jattach tool (docker-solr#321) Add gsed to mac requirement. Needed to build docs repo Update maintainer information (docker-solr#313) Make solr-create more stable. Follow-up fix similar to docker-solr#311 (docker-solr#312) Fix race condition in wait-for-solr.sh (docker-solr#311)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #310.
Script is failing to detect Solr instance as alive due to a race condition between two commands in a pipe.
Solution is:
I tested it for Solr 8.5.1, under Mac and docker-machine only.
Issue can be reproduced (depending on the environment), using this docker-compose.yml file.