Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crux: Add mutli-arch builds and new (old) version #5073

Merged
merged 2 commits into from
Nov 21, 2018
Merged

crux: Add mutli-arch builds and new (old) version #5073

merged 2 commits into from
Nov 21, 2018

Conversation

lag-linaro
Copy link
Contributor

Cc: @prologic

Signed-off-by: Lee Jones lee.jones@linaro.org

odidev
odidev reviewed Nov 16, 2018
View reviewed changes
Copy link
Contributor

@odidev odidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lag-linaro
Please have a look at architecture nomenclature.
I haven't observed aarch64 named arch in other modules, and instead arm64v8 is being used in those modules.

Regards,

library/crux Outdated Show resolved Hide resolved
crux: Add mutli-arch builds and new (old) version
92a7b47 
Signed-off-by: Lee Jones <lee.jones@linaro.org>
@odidev
Copy link
Contributor

odidev commented Nov 16, 2018

Okay, So changes are required in travis too, to incorporate cruxlinux instead of crux

tianon
tianon reviewed Nov 16, 2018
View reviewed changes
library/crux Outdated Show resolved Hide resolved
@lag-linaro
Copy link
Contributor Author

I'm struggling to see why Travis is failing on this change.

Is a global GitCommit: required?

@odidev
Copy link
Contributor

odidev commented Nov 16, 2018

Although, I am not an expert in this. But this is what I can think of.

  • Travis is not even able to find GitRepo.
    This is the error: error: failed fetching repo crux```
    So it is looking for crx instead of cruxlinux

According, to travis.sh script, it is stripping /library/crux to crux.

After this, it tries to execute commands for "crux", which then doesn't have any GitRepo path.

I will keep on checking and get back to you, once i find something conclusive

@lag-linaro
Copy link
Contributor Author

  • Travis is not even able to find GitRepo.
    This is the error: error: failed fetching repo crux```
    So it is looking for crx instead of cruxlinux

It gets the name crux from the library file. The repo should be fetched using the GitRepo: tag.

According, to travis.sh script, it is stripping /library/crux to crux.

Exactly (see above).

After this, it tries to execute commands for "crux", which then doesn't have any GitRepo path.

The GitRepo: path is provided.

@tianon
Copy link
Member

tianon commented Nov 20, 2018

@prologic can you confirm that you're both OK with this update and OK with still being listed as the image Maintainer:? (Perhaps adding @lag-linaro as an official co-maintainer?)

@prologic
Copy link
Contributor

OK on all 3 counts :) Up to @lag-linaro if he wants to be listed as co-maintainer :)

@lag-linaro
Copy link
Contributor Author

@lag-linaro sure, go for it.

The repo should be super trivial to maintain now.

@lag-linaro
Copy link
Contributor Author

@tianon would you be able to shed some light on why Travis is failing please?

@tianon
Copy link
Member

tianon commented Nov 20, 2018

You do need a non-arch-specific GitCommit value for each entry (it doesn't necessarily need to be global, but in this case it makes sense to just add a global one IMO). Here's what I'd recommend: (pulling the top-level GitCommit value from the master branch so that if it accidentally gets used somewhere, it fails to build instead of pulling the wrong bits accidentally)

Maintainers: James Mills <prologic@shortcircuit.net.au> (@prologic),
             Lee Jones (@lag-linaro)
GitRepo: https://github.com/cruxlinux/docker-crux.git
GitCommit: 26d68b9fbd54b774c53558faf2d3f1f94048c89a

Tags: 3.4, latest
Architectures: amd64, arm64v8
amd64-GitFetch: refs/heads/release-3.4-x86_64
amd64-GitCommit: da081a9004c5559cd77a1e2c2521193ccb2afdd2
arm64v8-GitFetch: refs/heads/release-3.4-aarch64
arm64v8-GitCommit: 9e26df864d2329a493b30b716ed36314509f0273

Tags: 3.2
Architectures: amd64, arm64v8
amd64-GitFetch: refs/heads/release-3.2-x86_64
amd64-GitCommit: 07e966125ba3d6d48a12489830917e8a9bc983a7
arm64v8-GitFetch: refs/heads/release-3.2-aarch64
arm64v8-GitCommit: bd3c44a73d37dc57b3295a3793cb7a6c544bc428

Email on the maintainer line is optional -- I'll let you decide if you'd like to list one there.

crux: Add global GitCommit: tag and list Lee Jones as project maintainer
60f926d 
Signed-off-by: Lee Jones <lee.jones@linaro.org>
@lag-linaro
Copy link
Contributor Author

Ah ha, it worked! \o/

Thanks @tianon

@tianon tianon mentioned this pull request Nov 21, 2018
Merged
@tianon
Copy link
Member

tianon commented Nov 21, 2018

Diffs: https://gist.github.com/docker-library-bot/d5cd0a6ad5eb825c75c561822ed79ee2

LGTM

Build test of #5073; 60f926d; amd64 (crux):

$ bashbrew build crux:3.4
Building bashbrew/cache:b1c8ca8be778284ca194f9d9d1947eec97a30e0ba635ed59dfaf678b6f91f954 (crux:3.4)
Tagging crux:3.4
Tagging crux:latest

$ test/run.sh crux:3.4
testing crux:3.4
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...warning: garbage password detected for 'bin': 'x'
warning: garbage password detected for 'messagebus': 'x'
warning: garbage password detected for 'mail': 'x'
warning: garbage password detected for 'ftp': 'x'
warning: garbage password detected for 'daemon': 'x'
warning: garbage password detected for 'nobody': 'x'
warning: garbage password detected for 'www': 'x'
passed
	'override-cmd' [4/4]...passed


$ bashbrew build crux:3.2
Building bashbrew/cache:384b91fbeb15c40ee2ddcd6bad5d1dd6c539baff203e55bb036a04447fa62a6c (crux:3.2)
Tagging crux:3.2

$ test/run.sh crux:3.2
testing crux:3.2
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...warning: garbage password detected for 'bin': 'x'
warning: garbage password detected for 'messagebus': 'x'
warning: garbage password detected for 'mail': 'x'
warning: garbage password detected for 'ftp': 'x'
warning: garbage password detected for 'daemon': 'x'
warning: garbage password detected for 'nobody': 'x'
warning: garbage password detected for 'www': 'x'
passed
	'override-cmd' [4/4]...passed

Build test of #5073; 60f926d; arm64v8 (crux):

$ bashbrew build crux:3.4
Building bashbrew/cache:b1dd38c2d24a46846693f5e9f9f00c96955263671bf1dc9a311785f5d5dc75bb (crux:3.4)
Tagging crux:3.4
Tagging crux:latest

$ test/run.sh crux:3.4
testing crux:3.4
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...warning: garbage password detected for 'bin': 'x'
warning: garbage password detected for 'messagebus': 'x'
warning: garbage password detected for 'mail': 'x'
warning: garbage password detected for 'ftp': 'x'
warning: garbage password detected for 'daemon': 'x'
warning: garbage password detected for 'nobody': 'x'
warning: garbage password detected for 'www': 'x'
passed
	'override-cmd' [4/4]...passed


$ bashbrew build crux:3.2
Building bashbrew/cache:99ee9b28829d00a8e331ebf2cf9e5f68514c0c16f5c53e9d4bdb02383e9f4ffb (crux:3.2)
Tagging crux:3.2

$ test/run.sh crux:3.2
testing crux:3.2
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...warning: garbage password detected for 'bin': 'x'
warning: garbage password detected for 'messagebus': 'x'
warning: garbage password detected for 'mail': 'x'
warning: garbage password detected for 'ftp': 'x'
warning: garbage password detected for 'daemon': 'x'
warning: garbage password detected for 'nobody': 'x'
warning: garbage password detected for 'www': 'x'
passed
	'override-cmd' [4/4]...passed

@tianon tianon merged commit f3d4052 into docker-library:master Nov 21, 2018
@lag-linaro
Copy link
Contributor Author

Thanks again @tianon.

@tianon tianon mentioned this pull request Nov 27, 2018
Merged
@tianon
Copy link
Member

tianon commented Jun 19, 2019

Friendly ping -- it's been ~209 days since this update (so we're probably overdue, especially given CRUX 3.5).

@tianon
Copy link
Member

tianon commented Dec 12, 2019

Friendly ping x2 -- CRUX 3.5 is still a thing but this image hasn't been updated in over a year now. 😰

@prologic
Copy link
Contributor

/cc the new maintainers @mcharytoniuk @wawrzek over at https://github.com/cruxlinux

@mcharytoniuk
Copy link

@tianon @prologic Sorry, I'll try to push it during the weekend.

@mcharytoniuk
Copy link

@tianon @prologic There is a release in the docker-crux repo. I will submit the new release to docker hub library now.

https://github.com/cruxlinux/docker-crux/tree/release-3.5-x86_64

mcharytoniuk added a commit to mcharytoniuk/official-images that referenced this pull request Dec 14, 2019
@mcharytoniuk
crux: add 3.5 amd64 version, update maintainers
929e8c3 
arm version is in progress
maintainers updated according to this comment: docker-library#5073 (comment)
@mcharytoniuk mcharytoniuk mentioned this pull request Dec 14, 2019
Closed
@tianon tianon mentioned this pull request Jun 24, 2020
Merged
@mbarbar
Copy link

mbarbar commented Nov 26, 2020

Has this made it to Docker Hub yet? The deprecation notice is still on the page and there is no 3.5 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odidev odidev odidev left review comments

@tianon tianon tianon left review comments

Assignees
No one assigned
Labels
library/crux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lag-linaro @odidev @tianon @prologic @mcharytoniuk @mbarbar @docker-library-bot