add solr #346
Merged
add solr #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| To run a single Solr server: | ||
|
|
||
| SOLR_CONTAINER=$(docker run -d -p 8983:8983 -t solr) |
There was a problem hiding this comment.
It might be easier for users to understand by using something like --name some-solr instead of capturing the container id. Also, feel free to used fenced code blocks with language when needed.
There was a problem hiding this comment.
Good idea; I'll make it so.
|
You should also run |
Use named container instead of capturing the container id Use fenced code blocks with language
|
LGTM; CI failure is just complaining about |
|
LGTM |
tianon
added a commit
that referenced
this pull request
Oct 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the solr image, see docker-library/official-images#1070