Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla Update #2462

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Joomla Update #2462

merged 6 commits into from
Jul 8, 2024

Conversation

Llewellynvdm
Copy link
Contributor

Update Joomla Docker documentation to improve clarity and enhance configuration options

  • Changed container network configuration to use Docker networks instead of linking containers.
  • Introduced new environment variables for database configuration:
    • JOOMLA_DB_PASSWORD_FILE: Path to a file containing the database password.
    • JOOMLA_DB_TYPE: Database type with options for "mysqli" and "pgsql".
  • Added environment variables for auto-deployment configuration:
    • JOOMLA_SITE_NAME, JOOMLA_ADMIN_USER, JOOMLA_ADMIN_USERNAME, JOOMLA_ADMIN_PASSWORD, JOOMLA_ADMIN_EMAIL
    • JOOMLA_EXTENSIONS_URLS, JOOMLA_EXTENSIONS_PATHS
    • JOOMLA_SMTP_HOST, JOOMLA_SMTP_HOST_PORT
  • Updated port mapping instructions to reflect the new network setup.
  • Corrected the Dockerfile reference link for adding additional PHP extensions.

These changes improve the setup process, provide more flexible configuration options, and correct outdated references.

…figuration options

- Changed container network configuration to use Docker networks instead of linking containers.
- Introduced new environment variables for database configuration:
  - `JOOMLA_DB_PASSWORD_FILE`: Path to a file containing the database password.
  - `JOOMLA_DB_TYPE`: Database type with options for "mysqli" and "pgsql".
- Added environment variables for auto-deployment configuration:
  - `JOOMLA_SITE_NAME`, `JOOMLA_ADMIN_USER`, `JOOMLA_ADMIN_USERNAME`, `JOOMLA_ADMIN_PASSWORD`, `JOOMLA_ADMIN_EMAIL`
  - `JOOMLA_EXTENSIONS_URLS`, `JOOMLA_EXTENSIONS_PATHS`
  - `JOOMLA_SMTP_HOST`, `JOOMLA_SMTP_HOST_PORT`
- Updated port mapping instructions to reflect the new network setup.
- Corrected the Dockerfile reference link for adding additional PHP extensions.

These changes improve the setup process, provide more flexible configuration options, and correct outdated references.
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me sans my minor nit about consistency (that isn't a blocker, to be clear), and the CI failure for formatting (which I'm happy to resolve for you if you want/need me to).

joomla/content.md Show resolved Hide resolved
@tianon
Copy link
Member

tianon commented Jul 5, 2024

(Oh, I don't have commit access to your PR as you've unchecked that option, so I'm happy to walk you though the formatting fixes if you'd prefer and want the assist, but I can't make them for you directly unless you enable the checkbox on this PR that would allow me to do so.)

@Llewellynvdm
Copy link
Contributor Author

For some reason I do/did not see that checkbox.

image

I would gladly enable the checkbox on this PR, but can't find it. So I will just pushed an update...

$ docker run --name some-%%REPO%% -e JOOMLA_DB_HOST=10.1.2.3:3306 \
-e JOOMLA_DB_USER=... -e JOOMLA_DB_PASSWORD=... -d %%REPO%%
$ docker run --name some-%%REPO%% --network some-network -e JOOMLA_DB_HOST=10.1.2.3:3306 \
-e JOOMLA_DB_USER=... -e JOOMLA_DB_PASSWORD=... -d %%IMAGE%%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be %%REPO%% or %%IMAGE%%

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be %%IMAGE%% and is an excellent catch we clearly missed previously! 😄

volumes:
- joomla_data:/var/www/html
networks:
- joomla_network
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also change this to some-network or is this okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine since it's self-contained in an example file that does create the network also.

@tianon
Copy link
Member

tianon commented Jul 8, 2024

I would gladly enable the checkbox on this PR, but can't find it.

😭 I guess maybe there's a setting on the joomla-docker org that's preventing it? Not sure 😞 ❤️

@tianon tianon merged commit 20d0481 into docker-library:master Jul 8, 2024
6 checks passed
@tianon
Copy link
Member

tianon commented Jul 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants