-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mariadb docs update #2080
mariadb docs update #2080
Conversation
9367503
to
699acfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions
As mentioned in #2708 docs documenting how to change the port, particular for host networking was requested. The example in "configuration without a cnf file section" was already the default anyway (utf8), so this was just replaced. Using MARIADB_ROOT_PASSWORD in the example to move away from MySQL naming (still supported however). Closes: docker-library#2078
This was added a while ago in MariaDB/mariadb-docker#376
gosu mysql -> --user mysql suggestion thanks @yosifkit Closes: #MariaDB/mariadb-docker/issues/390
Co-authored-by: yosifkit <yosifkit@gmail.com>
f15fd66
to
885e1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine -- just a few minor review comments (for your consideration) and one markdown formatting bug 👀
I don't feel strongly about any of these though, and am happy to merge as-is if you'd rather. 👍
Formatting on INSTALL SONAME Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
Compressed backup simplier Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
better use of apt-get arguments Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
Nice improvements, thanks. Ready when you/ci is. |
A collection of updates and new content.