Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArangoDB] Add section about Limiting resource utilization #1721

Merged
merged 2 commits into from
May 26, 2020
Merged

[ArangoDB] Add section about Limiting resource utilization #1721

merged 2 commits into from
May 26, 2020

Conversation

Simran-B
Copy link
Contributor

tianon
tianon reviewed May 20, 2020
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few suggestions based on our fork of markdownfmt (which is what the CI failure is).

I'm also going to cc the arangodb image maintainers for confirmation/review: @fceller @dothebart @KVS85

arangodb/content.md Outdated Show resolved Hide resolved
arangodb/content.md Outdated Show resolved Hide resolved
arangodb/content.md Outdated Show resolved Hide resolved
@dothebart
Copy link
Contributor

@tianon thanks, I've discussed with my collegue @Simran-B (who is mainly responsible for the arangodb documentation) to create this PR beforehand.

Hope you like it, as we seem to have users having problems about arangodb not adjusting memory usage.
We found it a bit of a pity to add this workaround, as without docker ArangoDB would use the proc filesystem to retrieve this information. Is there any easy (or default by convention) way for a programm to determine its memory resources in a docker container to have a more common sense or at best automatic solution for this?

Cheers from Cologne,
Willi

@yosifkit
Copy link
Member

Is there any easy (or default by convention) way for a programm to determine its memory resources in a docker container to have a more common sense or at best automatic solution for this?

I think the canonical place is /sys/fs/cgroup/memory/memory.limit_in_bytes (https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt), but that may be different in future systems using cgroup-v2 (https://www.kernel.org/doc/Documentation/cgroup-v2.txt).

@Simran-B @tianon
Apply suggestions from code review (markdownfmt)
a75fae1 
Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
@dothebart dothebart mentioned this pull request May 25, 2020
Closed
@tianon
Copy link
Member

tianon commented May 26, 2020

arangodb/arangodb#11682 looks nice! 👍

Do you still want to merge this PR in the interim? (just double checking before I hit merge 😄)

@Simran-B
Copy link
Contributor Author

Simran-B commented May 26, 2020 via email

@tianon tianon merged commit e7b5cbf into docker-library:master May 26, 2020
@Simran-B Simran-B deleted the patch-1 branch January 17, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Simran-B @dothebart @yosifkit @tianon