This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
Fix race-y channel close/error assignment #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data race occurred when assigning to err and then subsequently reading it from anywhere else. Moving the channel close down could potentially help, but far easier to just gate both with a sync.Once since this isn't a code path that seems like it needs to be super-performant. Changes cause CloseWithError to be call-able once, ensuring that there's no case where err is written to while being read (as would happen when closing and reading c.err from another goroutine the moment c.closed is closed). Signed-off-by: Noel Cower <ncower@gmail.com>
Current coverage is 15.97% (diff: 0.00%)@@ master #21 diff @@
==========================================
Files 13 13
Lines 1131 1127 -4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 180 180
+ Misses 903 899 -4
Partials 48 48
|
|
Working on throwing together a small-ish example to reproduce this without dumping all my code somewhere. However, it should hopefully be visible with |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data race occurred when assigning to err and then subsequently reading
it from anywhere else. Moving the channel close down could potentially
help, but far easier to just gate both with a sync.Once since this
isn't a code path that seems like it needs to be super-performant.
Changes cause CloseWithError to be call-able once, ensuring that
there's no case where err is written to while being read (as would
happen when closing and reading c.err from another goroutine the moment
c.closed is closed).
Signed-off-by: Noel Cower ncower@gmail.com