change pre-build to pre_build to remove confusion #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@londoncalling, do I need to remove the formatting too to ensure it's not mistaken as a command? Or should I explicitly mention that it's the name of a file? |
|
@shubheksha I think that would be good, if you are around, sure make that change. But I'll merge this soon, and if you haven't made that minor change, I can do it. Looks great! |
|
LGTM 👍 |
johndmulhausen
pushed a commit
that referenced
this pull request
Apr 18, 2017
* change pre-build to pre_build to remove confusion * clarify that pre_build hook refers to a file
|
Awesome, guys! |
johndmulhausen
added a commit
that referenced
this pull request
Apr 18, 2017
* Create index.md * Create part2.md * Create part3.md * Create part4.md * Create part5.md * Rewrite step 2 * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update index.md * Rewrite of part 3 * Tabs-based swarm instructions, pass 1 * Rewrite of parts 3 and 4, tabs implementation * Navigation, rewrites, part 4 completion * Part 5 w/Redis * Part 5, compelte Redis, rename part 6 * TOC/redirect implementation * Update part6.md * Changing links to point to new tutorial * Rewrites and asciinemas * Fix overview * Label diagrams * Fix button * Fix link to where Stacks are covered * Fix typo * s/file/directory * Reformat paragraph * Shorten tabs * Typos * Release DTR 2.2.4, 2.1.6 * Go back to small /edge (#2736) * Go back to small /edge * Update site front page Add info about Editions Reorganize components Update headings * Move logic of fetching content to a script * Add v1.28 API * Add info about versioned API * Fix a few 404s (#2785) * Fix typo * Propose use of another word (#2791) I think that interested is better than invested, in this case. * Update secrets.md (#2780) remove correct secret * Change mount syntax on windows from //c/ to c:\ (#2761) LGTM * Update hackathon.md (#2773) * nodes.md grammar correction (#2802) * Grammar and formatting check (#2797) * Wrong article If the first word starts with a vowel sound you use an. If the first word has a consonant sound use a. * Making the text bold Removing backticks because probably the text needs to be bold and not marked as code. * Update overview.md (#2805) It should say 'predecessors', not 'successors'. Otherwise the sentence and the subsequent example don't make sense. * shrink some big images (#2798) Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> * #2627 (#2804) - Fix right sidebar overflow on rescale * Update hackathon.md * change pre-build to pre_build to remove confusion (#2813) * change pre-build to pre_build to remove confusion * clarify that pre_build hook refers to a file * Update TOC to sentence case (#2790) * add more info about DTR on the overview page (#2794) fix #1904 * Update glossary.yaml (#2807) Fix #2575. * fix imports since docker api pkg migration, fix example repository name to be canonical (#2806) * tweak: code format for filename (#2829) * tweak: code format for filename slight reword, so as to avoid confusion w/filename Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * small changes just to kick build again Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * Update hackathon.md * fix broken links (#2808) * fix broken link (#2809) * [CONTRIBUTING] update broken link (#2826) * [Debian] add gnupg2 requirement for stretch (#2823) * TOC/redirect implementation * Changing links to point to new tutorial * Rewrites and asciinemas * Fix bad merge * Metadata, formatting * Front page formatting, link instrumentation
joeuo
pushed a commit
to joeuo/docker.github.io
that referenced
this pull request
Apr 18, 2017
* Create index.md * Create part2.md * Create part3.md * Create part4.md * Create part5.md * Rewrite step 2 * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update index.md * Rewrite of part 3 * Tabs-based swarm instructions, pass 1 * Rewrite of parts 3 and 4, tabs implementation * Navigation, rewrites, part 4 completion * Part 5 w/Redis * Part 5, compelte Redis, rename part 6 * TOC/redirect implementation * Update part6.md * Changing links to point to new tutorial * Rewrites and asciinemas * Fix overview * Label diagrams * Fix button * Fix link to where Stacks are covered * Fix typo * s/file/directory * Reformat paragraph * Shorten tabs * Typos * Release DTR 2.2.4, 2.1.6 * Go back to small /edge (docker#2736) * Go back to small /edge * Update site front page Add info about Editions Reorganize components Update headings * Move logic of fetching content to a script * Add v1.28 API * Add info about versioned API * Fix a few 404s (docker#2785) * Fix typo * Propose use of another word (docker#2791) I think that interested is better than invested, in this case. * Update secrets.md (docker#2780) remove correct secret * Change mount syntax on windows from //c/ to c:\ (docker#2761) LGTM * Update hackathon.md (docker#2773) * nodes.md grammar correction (docker#2802) * Grammar and formatting check (docker#2797) * Wrong article If the first word starts with a vowel sound you use an. If the first word has a consonant sound use a. * Making the text bold Removing backticks because probably the text needs to be bold and not marked as code. * Update overview.md (docker#2805) It should say 'predecessors', not 'successors'. Otherwise the sentence and the subsequent example don't make sense. * shrink some big images (docker#2798) Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> * docker#2627 (docker#2804) - Fix right sidebar overflow on rescale * Update hackathon.md * change pre-build to pre_build to remove confusion (docker#2813) * change pre-build to pre_build to remove confusion * clarify that pre_build hook refers to a file * Update TOC to sentence case (docker#2790) * add more info about DTR on the overview page (docker#2794) fix docker#1904 * Update glossary.yaml (docker#2807) Fix docker#2575. * fix imports since docker api pkg migration, fix example repository name to be canonical (docker#2806) * tweak: code format for filename (docker#2829) * tweak: code format for filename slight reword, so as to avoid confusion w/filename Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * small changes just to kick build again Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * Update hackathon.md * fix broken links (docker#2808) * fix broken link (docker#2809) * [CONTRIBUTING] update broken link (docker#2826) * [Debian] add gnupg2 requirement for stretch (docker#2823) * TOC/redirect implementation * Changing links to point to new tutorial * Rewrites and asciinemas * Fix bad merge * Metadata, formatting * Front page formatting, link instrumentation
joeuo
pushed a commit
to joeuo/docker.github.io
that referenced
this pull request
Apr 18, 2017
* Create index.md * Create part2.md * Create part3.md * Create part4.md * Create part5.md * Rewrite step 2 * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update part2.md * Update index.md * Rewrite of part 3 * Tabs-based swarm instructions, pass 1 * Rewrite of parts 3 and 4, tabs implementation * Navigation, rewrites, part 4 completion * Part 5 w/Redis * Part 5, compelte Redis, rename part 6 * TOC/redirect implementation * Update part6.md * Changing links to point to new tutorial * Rewrites and asciinemas * Fix overview * Label diagrams * Fix button * Fix link to where Stacks are covered * Fix typo * s/file/directory * Reformat paragraph * Shorten tabs * Typos * Release DTR 2.2.4, 2.1.6 * Go back to small /edge (docker#2736) * Go back to small /edge * Update site front page Add info about Editions Reorganize components Update headings * Move logic of fetching content to a script * Add v1.28 API * Add info about versioned API * Fix a few 404s (docker#2785) * Fix typo * Propose use of another word (docker#2791) I think that interested is better than invested, in this case. * Update secrets.md (docker#2780) remove correct secret * Change mount syntax on windows from //c/ to c:\ (docker#2761) LGTM * Update hackathon.md (docker#2773) * nodes.md grammar correction (docker#2802) * Grammar and formatting check (docker#2797) * Wrong article If the first word starts with a vowel sound you use an. If the first word has a consonant sound use a. * Making the text bold Removing backticks because probably the text needs to be bold and not marked as code. * Update overview.md (docker#2805) It should say 'predecessors', not 'successors'. Otherwise the sentence and the subsequent example don't make sense. * shrink some big images (docker#2798) Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> * docker#2627 (docker#2804) - Fix right sidebar overflow on rescale * Update hackathon.md * change pre-build to pre_build to remove confusion (docker#2813) * change pre-build to pre_build to remove confusion * clarify that pre_build hook refers to a file * Update TOC to sentence case (docker#2790) * add more info about DTR on the overview page (docker#2794) fix docker#1904 * Update glossary.yaml (docker#2807) Fix docker#2575. * fix imports since docker api pkg migration, fix example repository name to be canonical (docker#2806) * tweak: code format for filename (docker#2829) * tweak: code format for filename slight reword, so as to avoid confusion w/filename Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * small changes just to kick build again Signed-off-by: Victoria Bialas <victoria.bialas@docker.com> * Update hackathon.md * fix broken links (docker#2808) * fix broken link (docker#2809) * [CONTRIBUTING] update broken link (docker#2826) * [Debian] add gnupg2 requirement for stretch (docker#2823) * TOC/redirect implementation * Changing links to point to new tutorial * Rewrites and asciinemas * Fix bad merge * Metadata, formatting * Front page formatting, link instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues (optional)
Fixes #2535