Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the jekyll-include-cache plugin to shave off some page building time #2290

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Use the jekyll-include-cache plugin to shave off some page building time #2290

merged 1 commit into from
Mar 14, 2017

Conversation

mdlinville
Copy link

This is a very naive first implementation which only caches truly static content like the footer and archives. If we could make use of this for building the left-hand nav tree, I think it would be pretty cool.

cc/ @allejo

@johndmulhausen
Copy link

Naive or no, this is actually as good as we can do without significantly changing the plumbing on treebuilder.html and tree.html. Absolutely everything else has per-page specificity that doesn't gain us anything.

Testing locally, it finished the build in 143 seconds. Ran the current master build and it finished in roughly the same time, so I don't think this buys us much but it sets the stage for us doing more with caching where we can.

@johndmulhausen johndmulhausen merged commit a02d805 into docker:master Mar 14, 2017
@johndmulhausen johndmulhausen self-assigned this Mar 14, 2017
mdlinville pushed a commit that referenced this pull request Mar 14, 2017
johndmulhausen pushed a commit that referenced this pull request Mar 14, 2017
…ilding time" (#2311)

* Revert "Release UCP 2.1.1"

This reverts commit 21bb932.

* Revert "Update step_six.md (#2309)"

This reverts commit d4822bf.

* Revert "Fix typo "visulizer" (#2297)"

This reverts commit 86fecbb.

* Revert "Update test-and-docs.md (#2293)"

This reverts commit 15f1780.

* Revert "Fix typo "commmands" (#2295)"

This reverts commit d867751.

* Revert "Use the jekyll-include-cache plugin to shave off some page building time (#2290)"

This reverts commit a02d805.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants