Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix endpoint mode loading from Compose file in stack deploy #32333

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Fix endpoint mode loading from Compose file in stack deploy #32333

merged 1 commit into from
Apr 4, 2017

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Apr 3, 2017

Fixes #32325

@dnephin dnephin force-pushed the fix-endpoint-mode branch from 3b021a7 to 20c6187 Compare April 3, 2017 21:46
@dnephin dnephin added this to the 17.04.0 milestone Apr 3, 2017
@dnephin
Fix endpoint mode in Compose format.
25f0086 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the fix-endpoint-mode branch from 20c6187 to 25f0086 Compare April 3, 2017 21:51
@vieux
Copy link
Contributor

vieux commented Apr 4, 2017

LGTM

@vieux
Copy link
Contributor

vieux commented Apr 4, 2017

@dnephin will go in 17.05

@dnephin dnephin modified the milestones: 17.05.0, 17.04.0 Apr 4, 2017
boaz0
boaz0 approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vdemeester vdemeester self-assigned this Apr 4, 2017
@vdemeester vdemeester self-requested a review April 4, 2017 08:26
vdemeester
vdemeester approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@thaJeztah
Copy link
Member

relates to #31795

@vdemeester vdemeester merged commit 93ffbb7 into moby:master Apr 4, 2017
@dnephin dnephin deleted the fix-endpoint-mode branch April 4, 2017 14:39
@dnephin dnephin mentioned this pull request Apr 13, 2017
Closed
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@vdemeester
Merge pull request moby#32333 from dnephin/fix-endpoint-mode
490d99b 
Fix endpoint mode loading from Compose file in stack deploy
@londoncalling londoncalling mentioned this pull request Jul 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boaz0 boaz0 boaz0 approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees

@vdemeester vdemeester

Labels
impact/changelog status/4-merge
Projects
None yet
Milestone
17.05.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dnephin @vieux @thaJeztah @vdemeester @boaz0 @GordonTheTurtle