Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker 1.8+ no longer needs dind #15596

Merged
merged 1 commit into from
Aug 21, 2015
Merged

docker 1.8+ no longer needs dind #15596

merged 1 commit into from
Aug 21, 2015
+71 −67

Conversation

jessfraz
Copy link
Contributor

ping @tianon idk what to make the entrypoint tbh or if you think this is too soon ;)

@jessfraz
Copy link
Contributor Author

hmm weird errors... need to investigate why...

@jessfraz
Copy link
Contributor Author

the windows side is because i need to update those servers

@thaJeztah
Copy link
Member

Is this still needed? https://github.com/docker/docker/blob/master/hack/dind#L14

@dmp42 dmp42 mentioned this pull request Aug 19, 2015
Closed
@tianon
Copy link
Member

tianon commented Aug 21, 2015

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll still be needed on older Docker versions, but making it do the mounting nonsense conditionally based on whether we've already got it all mounted seems really sane. 👍 (ie, if ! mountpoint -q /sys/fs/cgroup; then ...)

@jessfraz
Copy link
Contributor Author

nice yeah

On Fri, Aug 21, 2015 at 10:23 AM, Tianon Gravi notifications@github.com
wrote:

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll
still be needed on older Docker versions, but making it do the mounting
nonsense conditionally based on whether we've already got it all mounted
seems really sane. [image: 👍](ie, if ! mountpoint -q /sys/fs/cgroup;
then ...)

—
Reply to this email directly or view it on GitHub
#15596 (comment).

@jessfraz
update hack/dind for 1.8 mounting of cgroups
c48ac77 
Signed-off-by: Jessica Frazelle <acidburn@docker.com>
@jessfraz jessfraz force-pushed the hack-dind-its-been-fun branch from 8145137 to c48ac77 Compare August 21, 2015 18:13
@tianon
Copy link
Member

tianon commented Aug 21, 2015

LGTM 🤘

@tianon
Copy link
Member

tianon commented Aug 21, 2015

(much easier to review via https://github.com/docker/docker/pull/15596/files?w=1 now)

jessfraz pushed a commit that referenced this pull request Aug 21, 2015
Merge pull request #15596 from jfrazelle/hack-dind-its-been-fun
9d22c7a 
docker 1.8+ no longer needs dind
@jessfraz jessfraz merged commit 9d22c7a into moby:master Aug 21, 2015
@jessfraz jessfraz deleted the hack-dind-its-been-fun branch August 21, 2015 20:51
tianon added a commit to docker-library/docker that referenced this pull request Aug 22, 2015
@tianon
Update DIND_COMMIT
12a3302 
See moby/moby#15596
@lox lox mentioned this pull request Aug 26, 2015
Closed
@phemmer phemmer mentioned this pull request Sep 2, 2015
Closed
This was referenced Sep 3, 2015
Closed
Closed
@thaJeztah thaJeztah mentioned this pull request Sep 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessfraz @thaJeztah @tianon @icecrime @GordonTheTurtle