Added support for cgroup_parent #2114
Conversation
|
Thanks for the contribution @mohitsoni The If you do a |
This change adds cgroup-parent support to compose project. It allows each service to specify a 'cgroup_parent' option. Signed-off-by: Mohit Soni <mosoni@paypal.com>
| service.image = lambda: {'Id': 'abc123'} | ||
|
|
||
| service.create_container(do_build=False, cgroup_parent='test') | ||
| self.assertFalse(self.mock_client.build.called) |
There was a problem hiding this comment.
I don't see how this test is testing that our cgroup_parent option was passed in correctly. I think this is the the wrong place to write the test for the option.
Maybe something along the lines to this test, https://github.com/docker/compose/blob/master/tests/unit/service_test.py#L111
where we can see that the cgroup_parent, if specified, is sent to create_host_config.
|
The test needs updating, other than that, the rest is LGTM 👍 |
|
Closing in favour of #2189 I picked up and did the test change, so we can get this in for 1.5 |
This change adds cgroup-parent support to compose project. It allows
each service to specify a 'cgroup_parent' option.
Related: