Refactor trust view command into a --pretty flag on trust inspect #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
dnephin
approved these changes
Mar 9, 2018
cli/command/trust/inspect.go
Outdated
| @@ -11,24 +12,56 @@ import ( | |||
| "github.com/theupdateframework/notary/tuf/data" | |||
| ) | |||
|
|
|||
| type inspectOptions struct { | |||
| remotes []string | |||
| /* FIXME(n4ss): this is consistent with `docker service inspect` but we should provide | |||
There was a problem hiding this comment.
go comments are generally done with // even if they are multi-line. /* */ is only used for package comments.
| @@ -17,24 +17,21 @@ import ( | |||
| "github.com/theupdateframework/notary/tuf/data" | |||
| ) | |||
|
|
|||
| /* TODO(n4ss): remove common tests with the regular inspect command */ | |||
|
some build failures as well |
n4ss
force-pushed
the
refactor-trust-inspect
branch
2 times, most recently
from
8f98b14 to
6cfc125
Compare
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
n4ss
force-pushed
the
refactor-trust-inspect
branch
from
6cfc125 to
8c3d0b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
+ Coverage 53.91% 53.92% +<.01%
==========================================
Files 262 262
Lines 16601 16605 +4
==========================================
+ Hits 8951 8954 +3
Misses 7050 7050
- Partials 600 601 +1 |
vieux
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nassim 'Nass' Eddequiouaq eddequiouaq.nassim@gmail.com
- What I did
docker trust viewwhich contains the same information asdocker trust inspectbut in a pretty-print format.--prettyflag ondocker trust inspect(same asdocker service inspect [--pretty]).docker trust viewto testdocker trust inspect --prettyinstead with the new output format (some duplicates tests are now present because the two original commands had some similar tests)docker trust inspect --pretty(olddocker trust view) now accepts several images as parameters to inspect (used to be limited to 1, butdocker trust inspectaccepts several images so we had to keep consistency)- How I did it
For now (I'll refactor that later),
docker trust inspectexecutes the old codepath if no--prettyflag is provided on the cli, otherwise executesdocker trust view's codepath for each image arguments.- How to verify it
$ make -f docker.Makefile testand
$ docker-dev trust inspect [--pretty] nginx:latest redis:latest docker:dind- Description for the changelog
docker trust viewto a--prettyflag ondocker trust inspect. Thedocker trust viewhas been removed.