Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-golang-mysql: add dev envs support #274

Merged
merged 3 commits into from
Jul 13, 2022
Merged

nginx-golang-mysql: add dev envs support #274

merged 3 commits into from
Jul 13, 2022

Conversation

milas
Copy link
Contributor

@milas milas commented Jul 11, 2022

  • Add Docker Desktop Development Environments config
  • Use nginx image with read-only bind mount instead of building a
    custom image
  • Upgrade Go dependencies

@milas
nginx-golang-mysql: add dev envs support
f122b52 
* Add Docker Desktop Development Environments config
* Use nginx image with read-only bind mount instead of building a
  custom image
* Upgrade Go dependencies

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas added this to the Dev Envs Support milestone Jul 11, 2022
@milas milas requested a review from a team July 11, 2022 19:15
@milas milas self-assigned this Jul 11, 2022
@milas
nginx-golang-mysql: update README
aa997c7 
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
glours
glours requested changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups 🤭

nginx-golang-mysql/backend/Dockerfile Outdated Show resolved Hide resolved
nginx-golang-mysql/.docker/docker-compose.yaml Outdated Show resolved Hide resolved
@milas @glours
nginx-golang-mysql: code review fixes
aae8ffb 
Co-authored-by: Guillaume Lours <guillaume@lours.me>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas force-pushed the devenvs-nginx-golang-mysql branch from 04e5812 to aae8ffb Compare July 13, 2022 12:47
@milas milas requested a review from glours July 13, 2022 12:47
@milas milas merged commit f329300 into docker:master Jul 13, 2022
@milas milas deleted the devenvs-nginx-golang-mysql branch July 13, 2022 13:06
andrewm4894 pushed a commit to andrewm4894/awesome-compose that referenced this pull request Jul 19, 2023
@milas @glours @andrewm4894
nginx-golang-mysql: add dev envs support (docker#274)
d9d96ef 
* Add Docker Desktop Development Environments config
* Use nginx image with read-only bind mount instead of building a
  custom image
* Upgrade Go dependencies

Co-authored-by: Guillaume Lours <guillaume@lours.me>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Andrew Maguire <andrewm4894@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

Assignees

@milas milas

Labels
None yet
Projects
None yet
Milestone
Dev Envs Support
Development

Successfully merging this pull request may close these issues.
2 participants
@milas @glours