Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configuration to use react-express-mongo sample with Docker Dev Environments feature #271

Merged
merged 1 commit into from
Jul 13, 2022
Merged

add configuration to use react-express-mongo sample with Docker Dev Environments feature #271

merged 1 commit into from
Jul 13, 2022

Conversation

glours
Copy link
Collaborator

@glours glours commented Jul 11, 2022

  • Add a dedicated Compose file in the .docker directory for Dev Env configuration
  • Add a new dev-envs stage for both backend and frontend Dockerfile
  • Update documentation

@glours
add configuration to use react-express-mongo sample with Docker Dev E…
de9b26f 
…nvironments feature

Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours glours added this to the Dev Envs Support milestone Jul 11, 2022
@glours glours requested a review from a team July 11, 2022 16:47
@glours glours self-assigned this Jul 11, 2022
laurazard
laurazard approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works fine :)

@glours glours merged commit 7431790 into docker:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurazard laurazard laurazard approved these changes

Assignees

@glours glours

Labels
None yet
Projects
None yet
Milestone
Dev Envs Support
Development

Successfully merging this pull request may close these issues.
2 participants
@glours @laurazard