Nginx/Node/Redis and Flask/Redis Compose example #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Ajeet Singh Raina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
ajeetraina
changed the title
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
|
Hello @ajeetraina |
Signed-off-by: Ajeet Singh Raina <ajeetraina@gmail.com>
glours
requested changes
Mar 9, 2022
There was a problem hiding this comment.
Thanks for your contribution @ajeetraina
Please don't remove existing sample even if your contribution provide a more complex example.
Next time can you make a PR per sample? It's easier to review and merge, and it avoids to block your whole samples if only one need some changes.
Can you remove the unnecessary nginx-node-redis directory?
You also need to reference the new samples in the main README.md file
Regarding the nginx-node-redis sample, I think it should make more sens to only have one directory with the build of the node backend:
- The image will be build only once
- Using the
hostnameproperty, resolved by compose DNS, in your js code will be efficient to replace your hardcodedres.send('web1: Total number of visits is: ' + numVisitsToDisplay);
glours
reviewed
Mar 9, 2022
|
Hi @glours I have made the changes. Let me know if it looks good. |
glours
requested changes
Mar 12, 2022
There was a problem hiding this comment.
@ajeetraina I can't merge this one, the Flask single service sample is still deleted in the PR 😞
I proposed you some changes to simplify the 2nd sample and remove duplicate code
|
You also need to sign all your commits and not only the last one, my bad |
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Ajeet Singh Raina <ajeetraina@gmail.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Co-authored-by: Guillaume Lours <guillaume@lours.me> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Co-authored-by: Guillaume Lours <guillaume@lours.me> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Co-authored-by: Guillaume Lours <guillaume@lours.me> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Ajeet Singh Raina <ajeetraina@gmail.com> Signed-off-by: ajeetraina <ajeetraina@gmail.com>
Signed-off-by: Ajeet Singh Raina <ajeetraina@gmail.com>
|
I checked git log and it does show that it is signed-off. I am not sure why its not working. |
glours
requested changes
Mar 15, 2022
Co-authored-by: Guillaume Lours <guillaume@lours.me>
Co-authored-by: Guillaume Lours <guillaume@lours.me>
glours
requested changes
Mar 15, 2022
Co-authored-by: Guillaume Lours <guillaume@lours.me>
glours
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a single PR for multiple docker-compose sample projects that implements visitor counter powered by the following stack -
Project #1
Project #2