Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate aspnet-mssql sample to .NET 5 🚀 #143

Merged
merged 3 commits into from
May 21, 2021
Merged

Migrate aspnet-mssql sample to .NET 5 🚀 #143

merged 3 commits into from
May 21, 2021

Conversation

stvansolano
Copy link
Contributor

  • Updated MVC app to .NET 5
  • Added SQL Server health check as nginx-aspnet-mysql sample
  • Updated README.md files accordingly

@stvansolano stvansolano changed the title Migrate aspnet-mysql sample to .NET 5 🚀 Migrate aspnet-mssql sample to .NET 5 🚀 May 18, 2021
@stvansolano
Copy link
Contributor Author

@aiordache please take a look ;)

@stvansolano
Updated MVC app to .NET 5
8119ab4 
Signed-off-by: GitHub <noreply@github.com>
@stvansolano
Added SQL Server health check
95e7eae 
Signed-off-by: GitHub <noreply@github.com>
@stvansolano
Updated README.md files with ASP.NET samples
348d693 
Signed-off-by: GitHub <noreply@github.com>
aiordache
aiordache approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@aiordache aiordache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aiordache aiordache merged commit 6ba8ef4 into docker:master May 21, 2021
archii pushed a commit to archii/awesome-compose that referenced this pull request Jul 22, 2021
@stvansolano @archii
Migrate aspnet-mssql sample to .NET 5 🚀 (docker#143)
3aeb832 
* Updated MVC app to .NET 5

Signed-off-by: GitHub <noreply@github.com>

* Added SQL Server health check

Signed-off-by: GitHub <noreply@github.com>

* Updated README.md files with ASP.NET samples

Signed-off-by: GitHub <noreply@github.com>
@NghiaNguyen170192
Copy link

Hi, @stvansolano. As I check on the Startup.cs. There is no connection to the database, also no DbContext on Controller.
These are just 2 standalone containers without any connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiordache aiordache

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stvansolano @NghiaNguyen170192 @aiordache