Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset] Add ZINC Dataset #5428

Merged
merged 20 commits into from
Mar 22, 2023
Merged

[Dataset] Add ZINC Dataset #5428

merged 20 commits into from
Mar 22, 2023

Conversation

ZhenyuLU-Heliodore
Copy link
Contributor

@ZhenyuLU-Heliodore ZhenyuLU-Heliodore commented Mar 6, 2023 •
edited
Loading

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@ZhenyuLU-Heliodore ZhenyuLU-Heliodore changed the title Add zinc [Dataset] Add ZINC Dataset Mar 6, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Commit ID: a5621a1

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 6, 2023

Commit ID: 05d60df

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

rudongyu commented Mar 7, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 7, 2023

Commit ID: dcc28166a09013bbb3ac2b873e03d64ffce3b9e7

Build ID: 3

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

rudongyu
rudongyu requested changes Mar 8, 2023
View reviewed changes
docs/source/api/python/dgl.data.rst Outdated Show resolved Hide resolved
python/dgl/data/zinc.py Outdated Show resolved Hide resolved
python/dgl/data/zinc.py Outdated Show resolved Hide resolved
python/dgl/data/zinc.py Outdated Show resolved Hide resolved
tests/python/common/data/test_data.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Commit ID: ca4a0499ed431951b973ef3dfcdfdfc0d05fe1ea

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Commit ID: 6979c20594761bd2672e83381ecd26cd8c58183e

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Commit ID: 5e4c405

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Commit ID: 1668820

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Commit ID: 59ef692

Build ID: 8

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 9, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@rudongyu
Copy link
Collaborator

@dgl-bot

@frozenbugs
Copy link
Collaborator

LGTM, @rudongyu feel free to merge.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 21, 2023

Commit ID: 1f47033

Build ID: 15

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: a54f505

Build ID: 16

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: a54f505

Build ID: 17

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 4b9ac2a

Build ID: 18

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 4b9ac2a

Build ID: 19

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 8aafc35

Build ID: 20

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 8aafc35

Build ID: 21

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 8aafc35

Build ID: 22

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 93b8643

Build ID: 23

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@rudongyu
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 22, 2023

Commit ID: 93b8643

Build ID: 24

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@rudongyu rudongyu merged commit 4534650 into dmlc:master Mar 22, 2023
chang-l pushed a commit to chang-l/dgl that referenced this pull request Mar 29, 2023
@ZhenyuLU-Heliodore @rudongyu @chang-l
[Dataset] Add ZINC Dataset (dmlc#5428)
495e6f6 
* Update dgl.data.rst

* Add files via upload

* Add files via upload

* Add files via upload

* Update zinc.py

* Update dgl.data.rst

* Update test_data.py

* Add files via upload

* Update cluster.py

* Update pattern.py

* Update zinc.py

* Update zinc.py

* Update test_data.py

* lint

* fix

* fix path

* update test on label shape

---------

Co-authored-by: rudongyu <ru_dongyu@outlook.com>
@ZhenyuLU-Heliodore ZhenyuLU-Heliodore deleted the add_ZINC branch April 9, 2023 15:41
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
@ZhenyuLU-Heliodore @rudongyu @DominikaJedynak
[Dataset] Add ZINC Dataset (dmlc#5428)
5a0d34c 
* Update dgl.data.rst

* Add files via upload

* Add files via upload

* Add files via upload

* Update zinc.py

* Update dgl.data.rst

* Update test_data.py

* Add files via upload

* Update cluster.py

* Update pattern.py

* Update zinc.py

* Update zinc.py

* Update test_data.py

* lint

* fix

* fix path

* update test on label shape

---------

Co-authored-by: rudongyu <ru_dongyu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozenbugs frozenbugs frozenbugs left review comments

@rudongyu rudongyu rudongyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhenyuLU-Heliodore @dgl-bot @rudongyu @frozenbugs