Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Tvm integration #2367

Merged
merged 30 commits into from
Dec 31, 2020
Merged

[Feature] Tvm integration #2367

merged 30 commits into from
Dec 31, 2020

Conversation

kira-lin
Copy link
Contributor

@kira-lin kira-lin commented Nov 25, 2020 •
edited by yzh119
Loading

Description

This branch enables dgl to call TVM AOT compiled modules. It adds a Tree reduction SDDMM as an example.

Checklist

  • SDDMM support more data types
  • handle loading libfeatgraph.so properly

@yzh119 yzh119 self-requested a review November 25, 2020 14:05
yzh119
yzh119 reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CMakeLists.txt Show resolved Hide resolved
cmake/tvm/pack_featgraph.py Outdated Show resolved Hide resolved
@yzh119 yzh119 changed the title Tvm integration [Feature][WIP] Tvm integration Dec 28, 2020
@yzh119 yzh119 changed the title [Feature][WIP] Tvm integration [Feature] Tvm integration Dec 29, 2020
@yzh119
Copy link
Member

yzh119 commented Dec 29, 2020

@jermainewang The PR is now ready for review.

@yzh119 yzh119 mentioned this pull request Dec 31, 2020
Closed
5 tasks
jermainewang
jermainewang approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@jermainewang jermainewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. some minor comments. Great job! @kira-lin and @yzh119

CMakeLists.txt Outdated Show resolved Hide resolved
featgraph/CMakeLists.txt Show resolved Hide resolved
featgraph/include/featgraph.h Show resolved Hide resolved
featgraph/pack_featgraph.py Outdated Show resolved Hide resolved
featgraph/src/featgraph.cc Outdated Show resolved Hide resolved
featgraph/src/featgraph.cc Outdated Show resolved Hide resolved
@yzh119 yzh119 merged commit 4208ce2 into dmlc:master Dec 31, 2020
@yzh119 yzh119 mentioned this pull request Jan 5, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 left review comments

@jermainewang jermainewang jermainewang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kira-lin @yzh119 @jermainewang