remove initilize and move :url attribute processing into cas.rb #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlindahl
pushed a commit
that referenced
this pull request
Nov 20, 2013
|
Merged and closed with 37d5c49 |
|
PS: Protips for your next open source contrib:
Thanks for the contribution! 🍻 |
|
Your comment is correct. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this does the same as my last attempt without removing the :url attribute. The two differences are url option is only extracted if present and validate_cas_setup is run each time. As with the existing code the cas_url is constructed each time. Now apps that use this can test server configurations without restarting the app.