Use NET5_0_OR_GREATER instead of NET5_0 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @starkpl, this was intentional based on advice I received that recycling collectors should be unnecessary in .NET 6.0 and that it can cause crashes: #72 (comment). However, I'm short on time these days so didn't have the time to independently verify the claims and the efficacy of the fix. I think this change should be good but there's a few small changes we should make, will leave some comments. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djluck was it intended to disable collector recycling for targets higher than net5? Could we just use NET5_0_OR_GREATER instead of NET5_0, so that we keep the recycling feature for net6 (and higher)?