Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sync s3 #193

Closed
Closed

Conversation

AdrienLemaire
Copy link

Hello guys,

This is a new feature pull request. I renamed the sync_media_s3 command into sync_s3, which sync by default both media and static files, and offers new options '--media-only' and '--static-only'.

Please read the commit messages for more details.
Also note that #192 will be outdated after that merge, but I'll take care of updating the patch afterwards.

Thanks

doc updated, filenames/paths updated. New behavior will be to upload media AND
static files, with option to upload only one of the other.

Serving static files from a cloud service makes sense and is mentionned in the
django doc (https://docs.djangoproject.com/en/dev/howto/static-files/).

This issue introduces several changes, therefore I'll ask you to merge this issue
first, and I will update django-extensions#192 afterwards
trailing spaces removed, unused sys import removed
 * You can give --media-only or --static-only to sync_s3.
 * self.DIRECTORY renamed in self.DIRECTORIES (string -> list)
 * sync_s3() will walk through all directories in DIRECTORIES
@trbs
Copy link
Member

trbs commented Oct 14, 2012

Could you update your pull request #193 and #192 to be able to merge with the current Django-Extensions ?

I would like to try and get this in the 1.0 release.

@adamhaney
Copy link

It would be super helpful to me if this were merged in. The patch would not go unnoticed or unappreciated.

@trbs
Copy link
Member

trbs commented Apr 4, 2013

Could you please update this pull request ?
So I can merge it in ?

@camilonova
Copy link
Member

@adamhaney @trbs I just updated the code so it can be integrated now see #380

@trbs trbs closed this Sep 30, 2013
trbs added a commit that referenced this pull request Oct 1, 2013
camilonova added a commit that referenced this pull request Apr 5, 2014
…_s3 command which is the officially supported. refs #129 #193 #445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants