Ensure generated file always contains a base name #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karyon
force-pushed
the
issue-775-add-block-name
branch
from
874a7b7 to
37ea2ca
Compare
…ash>.<ext> to <name>.<hash>.<ext> * The default name is set to output. This helps with Whitenoise integration as only files named as <name>.<hash>.<ext> will be considered immutable. * Use the block_name as the name if it's provided in the template tag. * When using single or multiple js/css files with no filters defined the basename of one of those files will be used for the name (this is existing behaviour). * Tests added and updated to support the name change.
karyon
force-pushed
the
issue-775-add-block-name
branch
from
37ea2ca to
088efe2
Compare
|
hi! sorry for the late reply. i have rebased the branch and resolved the merge conflicts, and right now i'm updating more places in the documentation, i have just one question, see next comment... |
karyon
reviewed
Aug 22, 2017
docs/usage.txt
Outdated
| @@ -27,15 +27,15 @@ Which would be rendered something like: | |||
|
|
|||
| .. code-block:: django | |||
|
|
|||
| <link rel="stylesheet" href="/static/CACHE/css/f7c661b7a124.css" type="text/css" charset="utf-8"> | |||
| <link rel="stylesheet" href="/static/CACHE/css/one.f7c661b7a124.css" type="text/css" charset="utf-8"> | |||
There was a problem hiding this comment.
this should be output. instead of one., right?
karyon
force-pushed
the
issue-775-add-block-name
branch
2 times, most recently
from
0e40280 to
42dea42
Compare
diox
approved these changes
Aug 23, 2017
|
@mgjbroadbent thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default output filename from [hash].[ext] to [name].[hash].[ext] in all cases.
This makes the output naming consistent with Whitenoise in all cases. This is because only files named as .. will be considered immutable, all other files will have the default 10 sec age set.
In addition, the user can customise the name using the block_name attribute.
This change was originally to solve #775, but this only changes the output naming convention.