Fixed #35141 -- Clarified the expected type of CACHE_MIDDLEWARE_SECONDS setting. #17776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Jan 25, 2024
felixxm
reviewed
Jan 25, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
e11bits
force-pushed
the
bugfix/35141_cache_middleware_seconds_can_be_set_to_a_float_but_has_to_be_an_int
branch
from
4856c1e to
3f6d939
Compare
|
I changed the PR as described in the ticket to just fix the docs for CACHE_MIDDLEWARE_SECONDS and the setting for that one test. PS: I don't know how I managed to close the PR and had to reopen it. Sorry. |
e11bits
force-pushed
the
bugfix/35141_cache_middleware_seconds_can_be_set_to_a_float_but_has_to_be_an_int
branch
from
8a67152 to
ff1f432
Compare
felixxm
force-pushed
the
bugfix/35141_cache_middleware_seconds_can_be_set_to_a_float_but_has_to_be_an_int
branch
from
ff1f432 to
2c52816
Compare
felixxm
changed the title
felixxm
reviewed
Jan 29, 2024
e11bits
force-pushed
the
bugfix/35141_cache_middleware_seconds_can_be_set_to_a_float_but_has_to_be_an_int
branch
from
2c52816 to
5bbe60a
Compare
|
@e11bits For the future, you don't need to rebase (and force push) after each commit to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address ticket https://code.djangoproject.com/ticket/35141
The changes are as proposed in the ticket.
This is my fifth PR for Django so please advise as you see fit.