Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle TaxRate events #1095

Merged
merged 5 commits into from
Jan 20, 2020
Merged

Handle TaxRate events #1095

merged 5 commits into from
Jan 20, 2020

Conversation

PabloCastellano
Copy link
Collaborator

Fixes #1094

@PabloCastellano PabloCastellano mentioned this pull request Jan 20, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 20, 2020 •
edited
Loading

Codecov Report

Merging #1095 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          25       25           
  Lines        2546     2546           
  Branches      230      230           
=======================================
  Hits         2484     2484           
  Misses         46       46           
  Partials       16       16
Impacted Files Coverage Δ
djstripe/event_handlers.py 99.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7ba43...ad7d58f. Read the comment docs.

@therefromhere
Copy link
Contributor

Thanks, looks good, I'll try add a quick test covering the event handler before I merge.

@therefromhere therefromhere merged commit cc3a082 into dj-stripe:master Jan 20, 2020
@therefromhere
Copy link
Contributor

Actually we don't have tests of the other update event handlers, so I'll skip that for now.

Merged, thanks!

therefromhere pushed a commit that referenced this pull request Jan 20, 2020
@PabloCastellano @therefromhere
Handle TaxRate events (#1095)
a0766c2 
Fixes #1094
@PabloCastellano PabloCastellano deleted the handle-tax-rate-events branch January 20, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhook is not syncing TaxRate model
2 participants
@PabloCastellano @therefromhere