Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.5 support #1085

Merged
merged 7 commits into from
Jan 13, 2020
Merged

Drop python 3.5 support #1085

merged 7 commits into from
Jan 13, 2020

Conversation

therefromhere
Copy link
Contributor

@therefromhere therefromhere commented Dec 22, 2019

Also removed IS_ASSERT_CALLED_AUTOSPEC_SUPPORTED from tests, since it should always be true on supported pythons

Resolves #1073

TODO

  • Update HISTORY.rst

Note - shouldn't be merged until after 2.2 release, based on #1066.

PabloCastellano and others added 5 commits November 30, 2019 17:38
EOL is December 2019
Also remove comment reference to Django 2.1
Also removed IS_ASSERT_CALLED_AUTOSPEC_SUPPORTED from tests,
since it should always be true on supported pythons

Resolves #1073
@therefromhere therefromhere added this to the 2.3.0 milestone Dec 22, 2019
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #1085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          25       25           
  Lines        2546     2546           
  Branches      230      230           
=======================================
  Hits         2484     2484           
  Misses         46       46           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acc184...96de879. Read the comment docs.

@therefromhere therefromhere mentioned this pull request Dec 22, 2019
@therefromhere therefromhere merged commit 5b7ba43 into master Jan 13, 2020
@therefromhere therefromhere deleted the drop_py35 branch January 13, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.5 support
2 participants