Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripe expired_uncaptured_charge refund reason #1076

Merged
merged 8 commits into from
Dec 13, 2019

Conversation

jcobacho
Copy link
Contributor

Included stripe "expired_uncaptured_charge" refund reason to RefundReason enum

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1076 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   97.59%   97.59%   +<.01%     
==========================================
  Files          25       25              
  Lines        2456     2457       +1     
  Branches      223      223              
==========================================
+ Hits         2397     2398       +1     
  Misses         45       45              
  Partials       14       14
Impacted Files Coverage Δ
djstripe/models/core.py 96.66% <ø> (ø) ⬆️
djstripe/enums.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b1e2e...a18e836. Read the comment docs.

@therefromhere
Copy link
Contributor

Thanks! Adding a unit test to check clean() works with all enum values would be good (see other enum field tests), I can maybe take a look at that before I merge.

Maybe this is the time when we should bump most/all enum fields to eg 64 chars to avoid migrations like this.

* Fixed refund.status (was the wrong enum)
* Allow blanks
@therefromhere
Copy link
Contributor

I've added a test, which also hit some unrelated issues.

Resolves #1075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants